After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794282 - debug-viewer: crash when max freq sentinel is 0
debug-viewer: crash when max freq sentinel is 0
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-devtools
git master
Other Linux
: Normal normal
: 1.13.91
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-03-13 10:26 UTC by Xabier Rodríguez Calvar
Modified: 2018-03-13 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.22 KB, patch)
2018-03-13 10:26 UTC, Xabier Rodríguez Calvar 		none Details | Review
patch (1.03 KB, patch)
2018-03-13 12:48 UTC, Xabier Rodríguez Calvar 		committed Details | Review

Description Xabier Rodríguez Calvar 2018-03-13 10:26:21 UTC 
Created attachment 369607 [details] [review]
patch

Division by 0.
Comment 1 Thibault Saunier 2018-03-13 11:50:15 UTC 
Review of attachment 369607 [details] [review]:

::: debug-viewer/GstDebugViewer/Plugins/Timeline.py
@@ +31,3 @@
 from gi.repository import Gdk
 import cairo
+import numpy as np

We have no dep on numpy, we should avoid bringing that dep in for such a simple thing :-)
Comment 2 Xabier Rodríguez Calvar 2018-03-13 12:48:47 UTC 
Created attachment 369613 [details] [review]
patch
Comment 3 Thibault Saunier 2018-03-13 13:22:51 UTC 
commit 8db603f8c845f194ecdaedf51a7aa2de739e40c4 (HEAD -> master, origin/master, origin/HEAD)
Author: Xabier Rodriguez Calvar <calvaris@igalia.com>
Date:   Tue Mar 13 13:48:00 2018 +0100

    debug-viewer: solved crash when maximum freq sentinel is 0

    https://bugzilla.gnome.org/show_bug.cgi?id=794282