Created attachment 369474 [details] [review]
Note about installing gnome-sushi

Patch with proposed change added. If you approve, please commit - I don't have commit access. Thanks!

The code style I've used so far is:

<if:test="platform:ubuntu">
  <note style="info package">
    <p>You need to install <app>gnome-sushi</app> to perform these steps.</p>
      <if:choose xmlns:if="http://projectmallard.org/if/1.0/">
        <if:when test="action:install">
        <p><link action="install:gnome-sushi"
           href="ftp://ftp.gnome.org/pub/gnome/sources/sushi/"
           style="button">Install gnome-sushi</link>
        </p>
      </if:when>
    </if:choose>
  </note>
</if>

Not sure if that's helpful / better.

Created attachment 369528 [details] [review]
Note about installing gnome-sushi 2

Thanks for submitting that example, André. A consistent appearance style is indeed good, so I submitted a new patch with a separate link button etc.

However, there are two reasons why I didn't follow the style completely:

1. AFAIK, that method for installing does not work on Debian based OSes like Ubuntu.[1]

2. I want the install button to show up also on the HTML version of the page.

   http://people.ubuntu.com/~gunnarhj/files-preview.html

So it would be great if someone could commit the new patch.


[1] This makes me fear that there is a need to have Debian/Ubuntu conditionals for all such install links. But that would be another, bigger project.

Review of attachment 369528 [details] [review]:

Thanks for the patch, committed as f7bcf724370e237af74f9bdb2839fea30dd25063.

Created attachment 369831 [details] [review]
Translators note

I propose the addition of a translators note as suggested here:

https://mail.gnome.org/archives/gnome-doc-list/2018-March/msg00084.html

Review of attachment 369831 [details] [review]:

Thank you, committed as ec1aedc09ed086c747a89a72486ae34bf3dd2b9a.