After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794182 - private_header regex is broken
private_header regex is broken
Status: RESOLVED FIXED
Product: gtk-doc
Classification: Platform
Component: general
1.27
Other Linux
: Normal normal
: 1.28
Assigned To: gtk-doc maintainers
gtk-doc maintainers
Depends on:
Blocks:
 
 
Reported: 2018-03-08 16:57 UTC by Yeti
Modified: 2018-03-19 19:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Yeti 2018-03-08 16:57:11 UTC 
The private header check now (both in 1.27 and master) looks like

        # If this is a private header, skip it.
        if re.search(r'%^\s*/\*\s*<\s*private_header\s*>\s*\*/', line):

AFAICT with the ‘%’ at the beginning the regex cannot actually match anything.  In any case it does not match existing private_header markers.

Removing the ‘%’ seems to be the fix.
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2018-03-19 18:59:20 UTC 
Yes, fallout from converting to python. Thanks for the report.
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2018-03-19 19:03:14 UTC 
commit 35992a3dc0a5a310839c25e800ec8192657231a9
Author: Stefan Sauer <ensonic@users.sf.net>
Date:   Mon Mar 19 20:01:17 2018 +0100

    scan: remove '%' that was missed in converting to py
    
    Fixes #794182