After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794180 - test_month_names fails unless installed
test_month_names fails unless installed
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: datetime
2.55.x
Other Linux
: Normal normal
: 2.56
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2018-03-08 16:41 UTC by Jan Alexander Steffens (heftig)
Modified: 2018-03-12 19:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tests: Skip the gdatetime month names test when running uninstalled (1.38 KB, patch)
2018-03-09 17:51 UTC, Philip Withnall 		committed Details | Review

Description Jan Alexander Steffens (heftig) 2018-03-08 16:41:48 UTC 
The gdatetime test suite in glib master (5d93dd63e) fails:

GLib:ERROR:gdatetime.c:1583:test_month_names: assertion failed (p == ("Juli")): ("July" == "Juli")

glib 2.54 is installed on the system. After installing the built glib 2.55, the test succeeds.

I suspect it's attempting to load its translations from the system instead of the tree.
Comment 1 Philip Withnall 2018-03-09 17:51:04 UTC 
Created attachment 369516 [details] [review]
tests: Skip the gdatetime month names test when running uninstalled

It needs the translations to be installed. See the comment added to the
code.

Signed-off-by: Philip Withnall <withnall@endlessm.com>
Comment 2 Philip Withnall 2018-03-09 17:51:44 UTC 
Here’s a fix. I’d like to get this in for 2.56, but it will need a freeze break request and a review. I’ll send the freeze break request now.
Comment 3 Philip Withnall 2018-03-12 19:24:40 UTC 
Review of attachment 369516 [details] [review]:

Reviewed by mclasen and ebassi on IRC.
Comment 4 Philip Withnall 2018-03-12 19:26:05 UTC 
Pushed to master for 2.56.0.

Attachment 369516 [details] pushed as c4f58e3 - tests: Skip the gdatetime month names test when running uninstalled