GNOME Bugzilla – Bug 794171
Fix warnings in Network panel code
Last modified: 2018-03-12 17:30:54 UTC
.
Created attachment 369431 [details] [review] network: Remove nagging code which removed from libnma This has been removed long ago and there are only stubs left for g-c-c. See also: https://bugzilla.gnome.org/show_bug.cgi?id=706964
Created attachment 369432 [details] [review] network: Fix warning about missing cast to GtkWidget*
Created attachment 369433 [details] [review] network: Fix deprecation warning related to NMVpnConnectionStateReason
Review of attachment 369431 [details] [review]: What replaces this functionality though? Are certificate errors ignored all the time now? Please link to a git web URL in the commit message, showing that nma_wifi_dialog_get_nag_ignored() always returns TRUE.
Review of attachment 369432 [details] [review]: Sure.
Review of attachment 369433 [details] [review]: Please copy the API docs that explain the enum renaming in the commit message.
Created attachment 369582 [details] [review] network: Remove dead code trying to use NMConnection as NMActiveConnection These code paths could never be hit as an NMConnection cannot be an NMVpnConnection which is a descendant of NMActiveConnection.
Review of attachment 369582 [details] [review]: That looks correct. Did you check that it still followed state correctly, or do we need to adapt this code instead of removing it?
Everything is working fine. The list of active connection changes, and things are matched against that reliably.
The following fixes have been pushed: 729db87 network: Remove dead code trying to use NMConnection as NMActiveConnection 72ef675 network: Fix warning about missing cast to GtkWidget* 3117e2d network: Remove nagging code which removed from libnma
Created attachment 369584 [details] [review] network: Remove dead code trying to use NMConnection as NMActiveConnection These code paths could never be hit as an NMConnection cannot be an NMVpnConnection which is a descendant of NMActiveConnection.
Created attachment 369585 [details] [review] network: Fix warning about missing cast to GtkWidget*
Created attachment 369586 [details] [review] network: Remove nagging code which removed from libnma This has been removed long ago and there are only stubs left for g-c-c. See also: - https://bugzilla.gnome.org/show_bug.cgi?id=706964 - https://git.gnome.org/browse/network-manager-applet/commit/?id=e21d598896ccd2c52850f52d21fe1d5aaa4e5410