After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794118 - Webrtc plugin recipe does not create .lib or include files in windows build
Webrtc plugin recipe does not create .lib or include files in windows build
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: cerbero
git master
Other All
: Normal blocker
: 1.13.91
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-03-06 13:47 UTC by o.f.e.r.a.c.h.l.e.r+gstreamer
Modified: 2018-03-12 14:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fixes the recipe file by adding the appropriate paths (1.66 KB, patch)
2018-03-06 13:50 UTC, o.f.e.r.a.c.h.l.e.r+gstreamer 		committed Details | Review

Description o.f.e.r.a.c.h.l.e.r+gstreamer 2018-03-06 13:47:47 UTC 
When creating a cross platform build (cerbero -c config/cross-win64.cbc package gstreamer-1.0), the gstwebrtc files are not included in the resulting tars.
Comment 1 o.f.e.r.a.c.h.l.e.r+gstreamer 2018-03-06 13:50:20 UTC 
Created attachment 369381 [details] [review]
Fixes the recipe file by adding the appropriate paths
Comment 2 Sebastian Dröge (slomo) 2018-03-06 14:12:52 UTC 
Thanks for the patch! You missed the plugin, which I've added too now

commit 8390c458208310652368fe2526f9095c7fb183fc (HEAD -> master)
Author: Ofer Achler <oachler@xsightsys.com>
Date:   Tue Mar 6 15:36:18 2018 +0200

    gst-plugins-bad: Include webrtc library, headers and plugin
    
    https://bugzilla.gnome.org/show_bug.cgi?id=794118
Comment 3 Matthew Waters (ystreet00) 2018-03-06 22:49:49 UTC 
Erm, the webrtc plugin will still not work with cerbero as the dtls elements aren't shipped.

The dtls elements depend on openssl which don't have a recipe for in cerbero.
Comment 4 Sebastian Dröge (slomo) 2018-03-07 10:22:23 UTC 
Hrm indeed, I completely forgot about that part
Comment 5 Tim-Philipp Müller 2018-03-12 11:20:18 UTC 
So now that we seem to have a working openssl recipe, can we re-enable this?

Or is anything else missing?
Comment 6 Nirbheek Chauhan 2018-03-12 14:38:21 UTC 
This all works now on Windows with this commit and some later ones:

https://cgit.freedesktop.org/gstreamer/cerbero/commit/?id=091250bc9d94cc6be8a646505823de9c112a6d71

I have tested it with gst-inspect-1.0 and gstwebrtc-demos (https://github.com/centricular/gstwebrtc-demos/).