After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793989 - pkgconfig: Add private zlib dependency for libgsttag
pkgconfig: Add private zlib dependency for libgsttag
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: 1.13.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-03-02 14:22 UTC by Edward Hervey
Modified: 2018-03-02 16:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
pkgconfig: Add private zlib dependency for libgsttag (1.45 KB, patch)
2018-03-02 14:22 UTC, Edward Hervey 		committed Details | Review

Description Edward Hervey 2018-03-02 14:22:26 UTC 
See patch
Comment 1 Edward Hervey 2018-03-02 14:22:31 UTC 
Created attachment 369188 [details] [review]
pkgconfig: Add private zlib dependency for libgsttag

Fixes issues with static application builds (which might not know
they need to link with zlib when using a libgsttag that was compiled
with it).
Comment 2 Tim-Philipp Müller 2018-03-02 14:28:23 UTC 
Comment on attachment 369188 [details] [review]
pkgconfig: Add private zlib dependency for libgsttag

I think this may need something more to make it work for the Meson build as well?
Comment 3 Edward Hervey 2018-03-02 14:42:57 UTC 
Consider the meson build never uses zlib, no :)
Comment 4 Edward Hervey 2018-03-02 16:39:14 UTC 
commit 865793273218739656fd9db9b5143ead5d33443c (HEAD -> master, origin/master, origin/HEAD)
Author: Edward Hervey <edward@centricular.com>
Date:   Fri Mar 2 15:21:25 2018 +0100

    pkgconfig: Add private zlib dependency for libgsttag
    
    Fixes issues with static application builds (which might not know
    they need to link with zlib when using a libgsttag that was compiled
    with it).
    
    https://bugzilla.gnome.org/show_bug.cgi?id=793989
Comment 5 Edward Hervey 2018-03-02 16:39:44 UTC 
I opened #793995 for the lack of zlib support in -base.