After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793942 - gstaggregator: pads must inherit from #GstAggregatorPad
gstaggregator: pads must inherit from #GstAggregatorPad
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other All
: Normal normal
: 1.13.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 793944 793945 793946
 
 
Reported: 2018-02-28 23:39 UTC by Mathieu Duponchelle
Modified: 2018-03-01 14:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gstaggregator: pads must inherit from #GstAggregatorPad (7.50 KB, patch)
2018-02-28 23:39 UTC, Mathieu Duponchelle 		committed Details | Review

Description Mathieu Duponchelle 2018-02-28 23:39:47 UTC 
Document this, and take advantage of that fact to use
GstAggregator.srcpad.segment instead of GstAggregator.segment
Comment 1 Mathieu Duponchelle 2018-02-28 23:39:52 UTC 
Created attachment 369120 [details] [review]
gstaggregator: pads must inherit from #GstAggregatorPad
Comment 2 Sebastian Dröge (slomo) 2018-03-01 08:25:43 UTC 
Comment on attachment 369120 [details] [review]
gstaggregator: pads must inherit from #GstAggregatorPad

Makes sense to me and seems cleaner than what we had before. However we don't do it like this in other base classes.

I'd be fine with merging after a second opinion :)
Comment 3 Mathieu Duponchelle 2018-03-01 14:31:09 UTC 
Attachment 369120 [details] pushed as 8c10f1e - gstaggregator: pads must inherit from #GstAggregatorPad