Created attachment 369107 [details] [review]
omxh265: update 422 profile names

h265parse is gaining support for the format range extension profile
(bgo#793876).
Use the profile names defined in h265parse.

Review of attachment 369107 [details] [review]:

::: omx/gstomxh265utils.c
@@ +37,3 @@
     return (OMX_VIDEO_HEVCPROFILETYPE) OMX_ALG_VIDEO_HEVCProfileMainStill;
+  } else if (g_str_equal (profile, "main-422")) {
+    /* Not standard: 8 bits variation of main-422-10 */

So this is only used for negotation / memory saving ? The bitstream will say main-422-10 right ?

Review of attachment 369107 [details] [review]:

::: omx/gstomxh265utils.c
@@ +37,3 @@
     return (OMX_VIDEO_HEVCPROFILETYPE) OMX_ALG_VIDEO_HEVCProfileMainStill;
+  } else if (g_str_equal (profile, "main-422")) {
+    /* Not standard: 8 bits variation of main-422-10 */

No, our OMX implmentation has its own format to define this new profile. It corresponds to the same flags as Main 4:2:2 10 except general_max_8bit_constraint_flag = 1.

Review of attachment 369107 [details] [review]:

::: omx/gstomxh265utils.c
@@ +40,2 @@
     return (OMX_VIDEO_HEVCPROFILETYPE) OMX_ALG_VIDEO_HEVCProfileMain422;
+  } else if (g_str_equal (profile, "main-422-10")) {

Would it be possible to re-use "gst_codec_utils_h265_get_profile" API from -base (and/or improve it if needed) ?

(In reply to Julien Isorce from comment #4)
> Review of attachment 369107 [details] [review] [review]:
> 
> ::: omx/gstomxh265utils.c
> @@ +40,2 @@
>      return (OMX_VIDEO_HEVCPROFILETYPE) OMX_ALG_VIDEO_HEVCProfileMain422;
> +  } else if (g_str_equal (profile, "main-422-10")) {
> 
> Would it be possible to re-use "gst_codec_utils_h265_get_profile" API from
> -base (and/or improve it if needed) ?

gst_codec_utils_h265_get_profile() is a parsing function (parses from profile_tier_level data). We are converting from the caps. In general we avoid pulling any dependency for that translation. We should fix that function to support the new profiles (except the custom one) of course.

Attachment 369107 [details] pushed as 5b55041 - omxh265: update 422 profile names

This realigns with the h265parse element.