After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793879 - x264enc: needs example for option-string
x264enc: needs example for option-string
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other All
: Normal enhancement
: 1.13.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-02-27 14:14 UTC by Alicia Boya García
Modified: 2018-02-27 18:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
x264enc: Add format example for option-string (1.06 KB, patch)
2018-02-27 14:44 UTC, Alicia Boya García 		committed Details | Review

Description Alicia Boya García 2018-02-27 14:14:00 UTC 
The format of option-string is not documented anywhere. I had to read gst_x264_enc_parse_options() to know how to add several options.
Comment 1 Alicia Boya García 2018-02-27 14:44:28 UTC 
Created attachment 369033 [details] [review]
x264enc: Add format example for option-string
Comment 2 Tim-Philipp Müller 2018-02-27 15:19:47 UTC 
Comment on attachment 369033 [details] [review]
x264enc: Add format example for option-string

Looks good. I'm wondering if we should perhaps drop the quotes though?
Comment 3 Alicia Boya García 2018-02-27 15:24:35 UTC 
Using some kind of pre-formatted text in the docs would be better than using quotes. Is that possible there with some kind of markup?
Comment 4 Tim-Philipp Müller 2018-02-27 15:40:53 UTC 
Don't think so :)
Comment 5 Nicolas Dufresne (ndufresne) 2018-02-27 18:52:46 UTC 
The quotes looks good in gst-inspect at least. This is just better then what we have, so merging now, thanks.
Comment 6 Nicolas Dufresne (ndufresne) 2018-02-27 18:56:17 UTC 
Attachment 369033 [details] pushed as 725de9b - x264enc: Add format example for option-string