After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793721 - xsettings: Don't export settings which GTK+ ignores
xsettings: Don't export settings which GTK+ ignores
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: xsettings
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks: 793720
 
 
Reported: 2018-02-22 13:24 UTC by Bastien Nocera
Modified: 2018-02-27 15:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
xsettings: Don't export settings which GTK+ ignores (4.14 KB, patch)
2018-02-22 13:25 UTC, Bastien Nocera 		none Details | Review
xsettings: Remove unused constants (1.37 KB, patch)
2018-02-22 15:04 UTC, Bastien Nocera 		committed Details | Review
xsettings: Hardcode GTK+ 3.x deprecated settings (6.86 KB, patch)
2018-02-22 15:05 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2018-02-22 13:24:57 UTC 
.
Comment 1 Bastien Nocera 2018-02-22 13:25:01 UTC 
Created attachment 368766 [details] [review]
xsettings: Don't export settings which GTK+ ignores

The backing GSettings don't exist anymore either.

See https://bugzilla.gnome.org/show_bug.cgi?id=793720
Comment 2 Bastien Nocera 2018-02-22 15:04:54 UTC 
Created attachment 368771 [details] [review]
xsettings: Remove unused constants

Those constants should have been removed along with the code that used
them in 8a51cd0.
Comment 3 Bastien Nocera 2018-02-22 15:05:00 UTC 
Created attachment 368772 [details] [review]
xsettings: Hardcode GTK+ 3.x deprecated settings

As GTK+ 3.x ignores the values of those settings and the backing
GSettings don't exist anymore either, hard-code those XSettings
for the benefit of GTK+ 2.x, and other toolkits that might consume
those.

See https://bugzilla.gnome.org/show_bug.cgi?id=793720
Comment 4 Bastien Nocera 2018-02-27 15:35:44 UTC 
Attachment 368771 [details] pushed as b2a9984 - xsettings: Remove unused constants
Attachment 368772 [details] pushed as 7100dbb - xsettings: Hardcode GTK+ 3.x deprecated settings