After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793696 - omx: implement ROI support on zynqultrascaleplus
omx: implement ROI support on zynqultrascaleplus
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-omx
git master
Other Linux
: Normal enhancement
: 1.14.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 793338
Blocks:
 
 
Reported: 2018-02-21 16:28 UTC by Guillaume Desmottes
Modified: 2018-03-28 08:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
videoenc: implement ROI on zynqultrascaleplus (7.42 KB, patch)
2018-02-21 16:36 UTC, Guillaume Desmottes 		committed Details | Review
omxvideoenc: add 'roi' qp-mode on zynqultrascaleplus (1.49 KB, patch)
2018-02-22 15:12 UTC, Guillaume Desmottes 		accepted-commit_now Details | Review

Description Guillaume Desmottes 2018-02-21 16:28:08 UTC 
The zynqultrascaleplus has a custom ROI OMX extension. Implement it using the new ROI meta data API (#793338).
Comment 1 Guillaume Desmottes 2018-02-21 16:36:27 UTC 
Created attachment 368721 [details] [review]
videoenc: implement ROI on zynqultrascaleplus

Check input buffers for ROI meta and pass them to the encoder by using
zynqultrascaleplus's custom OMX extension. Also add a new
"default-roi-quality" in order to tell the encoder what quality level
should be applied to ROI by default.
Comment 2 Nicolas Dufresne (ndufresne) 2018-02-21 17:31:51 UTC 
Attachment 368721 [details] pushed as 6921568 - videoenc: implement ROI on zynqultrascaleplus
Comment 3 Guillaume Desmottes 2018-02-22 15:12:10 UTC 
Re-opening as we need to add an extra qp-mode.
Comment 4 Guillaume Desmottes 2018-02-22 15:12:27 UTC 
Created attachment 368774 [details] [review]
omxvideoenc: add 'roi' qp-mode on zynqultrascaleplus

New QP mode used to handle ROI metadata.
Comment 5 Nicolas Dufresne (ndufresne) 2018-03-27 18:02:22 UTC 
Guillaume, friendly reminder that you can merge this. This should go in 1.14, as it's otherwise unusable.
Comment 6 Guillaume Desmottes 2018-03-28 08:17:51 UTC 
Pushed to 1.14 (e7604e2c5ef043862daf45633f3df6475ee6eeae) and master (530a7537cfd57f29497f8723f33b9f72622a357b)

Thanks for the reminder.