After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793686 - Unneeded BLIT operation when target is encoder (ex: vaapih264enc)
Unneeded BLIT operation when target is encoder (ex: vaapih264enc)
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gstreamer-vaapi
1.12.x
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-02-21 09:32 UTC by philippe.lecluse
Modified: 2018-11-03 15:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description philippe.lecluse 2018-02-21 09:32:29 UTC 
This operation 
12.4/gstreamer-vaapi-1.12.4/gst-libs/gst/vaapi/gstvaapifilter.c:  pipeline_param->output_background_color = 0xff000000;
force BLIT usage (visible with Vtune or intel_gpu_top) - or this is only needed when target is Display... useless when target is encoder (where Alpha is ignored)

This cause extra HW resource usage that can be prevented as this operation is not needed in encoder cases

Can we make this output_background_color configurable (or skip this operation in encode pipeline) ?
Comment 1 sreerenj 2018-02-21 22:32:28 UTC 
Yup, intel-vaapi-driver uses BLIT to clear the background color.

Maybe we can just use output_background_color "0" always to avoid unnecessary HW usage.
Let's wait for other developers to comment...
Comment 2 Víctor Manuel Jáquez Leal 2018-03-23 17:29:25 UTC 
As it is hard to tell when the vaapipostproc is used for encoding upstream or for anything else, I would remove it, but it is not clear to me what would imply in not encoding use cases, such as EGL textures, where the GstVaapiFilter is used.

And option would be to add a property to GstVaapiFilter to set the background color, and set it to zero by default. Only set 0xff000000 when handling EGL texture or the output color space is alfa (GST_VIDEO_INFO_HAS_ALPHA)
Comment 3 GStreamer system administrator 2018-11-03 15:53:11 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/issues/84.