After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793523 - matroskademux: Add comment about Opus clipping
matroskademux: Add comment about Opus clipping
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal enhancement
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-02-16 22:50 UTC by Alicia Boya García
Modified: 2018-04-13 08:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
matroskademux: Add comment about Opus clipping (1.32 KB, patch)
2018-02-16 22:50 UTC, Alicia Boya García
committed Details | Review

Description Alicia Boya García 2018-02-16 22:50:47 UTC
When I first read this code I thought somebody had forgot about the declared
sample rate and just assumed it to always be 48000 Hz in matroskademux.

Some days passed, and I was working on a opusparse bug when I again found the
48000 magic number. That made me suspicious. I tried encoding some audio at
24000 Hz. It worked, but why? I kept looking and finally I read the opusdec
code where the actual sample clipping was done. Then I knew and everything was
obvious.

This patch is for the me of the past who did not.
Comment 1 Alicia Boya García 2018-02-16 22:50:51 UTC
Created attachment 368448 [details] [review]
matroskademux: Add comment about Opus clipping