After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793503 - srt: Add support for streamheaders to sinks
srt: Add support for streamheaders to sinks
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal enhancement
: 1.13.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-02-16 08:20 UTC by Jan Alexander Steffens (heftig)
Modified: 2018-02-23 20:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
srt: Remove unused queued_buffers field (1.82 KB, patch)
2018-02-16 08:21 UTC, Jan Alexander Steffens (heftig) 		committed Details | Review
srt: Add gst_srt_base_sink_stop (2.33 KB, patch)
2018-02-16 08:21 UTC, Jan Alexander Steffens (heftig) 		committed Details | Review
srt: Refactor gst_srt_*_sink_send_buffer, extract send (3.61 KB, patch)
2018-02-16 08:21 UTC, Jan Alexander Steffens (heftig) 		committed Details | Review
srt: Add support for streamheaders to sinks (8.45 KB, patch)
2018-02-16 08:21 UTC, Jan Alexander Steffens (heftig) 		none Details | Review
srt: Add support for streamheaders to sinks (8.45 KB, patch)
2018-02-16 14:54 UTC, Jan Alexander Steffens (heftig) 		committed Details | Review

Description Jan Alexander Steffens (heftig) 2018-02-16 08:20:42 UTC 
Not sure how useful this is. I tested it with Matroska, which successfully starts demuxing from the middle of the stream. However, Matroska doesn't tolerate message loss so isn't suitable for SRT.
Comment 1 Jan Alexander Steffens (heftig) 2018-02-16 08:21:39 UTC 
Created attachment 368401 [details] [review]
srt: Remove unused queued_buffers field
Comment 2 Jan Alexander Steffens (heftig) 2018-02-16 08:21:44 UTC 
Created attachment 368402 [details] [review]
srt: Add gst_srt_base_sink_stop
Comment 3 Jan Alexander Steffens (heftig) 2018-02-16 08:21:49 UTC 
Created attachment 368403 [details] [review]
srt: Refactor gst_srt_*_sink_send_buffer, extract send
Comment 4 Jan Alexander Steffens (heftig) 2018-02-16 08:21:54 UTC 
Created attachment 368404 [details] [review]
srt: Add support for streamheaders to sinks
Comment 5 Jan Alexander Steffens (heftig) 2018-02-16 14:54:46 UTC 
Created attachment 368426 [details] [review]
srt: Add support for streamheaders to sinks

gst_buffer_list_add consumes the reference to the buffer.
Use g_value_dup_boxed instead of gst_value_get_buffer to get a new reference.
Comment 6 Olivier Crête 2018-02-23 20:50:31 UTC 
Looks good, I pushed everything!

Attachment 368401 [details] pushed as 4039bdb - srt: Remove unused queued_buffers field
Attachment 368402 [details] pushed as 7463a93 - srt: Add gst_srt_base_sink_stop
Attachment 368403 [details] pushed as 8a5dab1 - srt: Refactor gst_srt_*_sink_send_buffer, extract send
Attachment 368426 [details] pushed as 37a9e0f - srt: Add support for streamheaders to sinks