GNOME Bugzilla – Bug 793425
Carry on using gtk-3.0's bookmarks file
Last modified: 2018-02-15 19:50:53 UTC
In https://gitlab.gnome.org/GNOME/gtk/blob/master/gtk/gtkbookmarksmanager.c#L76 filename = g_build_filename (g_get_user_config_dir (), "gtk-4.0", "bookmarks", NULL); There's no reason to use a separate file until the format of the file changes though, as this just means that GTK+ 3.x and GTK+ 4.x applications would end up showing different bookmarks in the file chooser.
I agree.
Created attachment 368370 [details] [review] gtkbookmarksmanager: Use GTK+ 3.0's bookmarks file There's no reason to use a separate file until the format of the file changes though, as this just means that GTK+ 3.x and GTK+ 4.x applications would end up showing different bookmarks in the file chooser.
Review of attachment 368370 [details] [review]: looks good, otherwise ::: gtk/gtkbookmarksmanager.c @@ +76,3 @@ + /* Use gtk-3.0's bookmarks file as the format didn't change. + * Add the 3.0 file format to get_legacy_bookmarks_file() when + * the format does change. */ Pet peeve of mine: Please put the */ on the next line and line up the stars
Created attachment 368387 [details] [review] gtkbookmarksmanager: Use GTK+ 3.0's bookmarks file There's no reason to use a separate file until the format of the file changes though, as this just means that GTK+ 3.x and GTK+ 4.x applications would end up showing different bookmarks in the file chooser.