Bug 793312 – gnome-clocks sometimes crashes when used from gnome-shell search.

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 793312 - gnome-clocks sometimes crashes when used from gnome-shell search.


Summary:	gnome-clocks sometimes crashes when used from gnome-shell search.


Status:	RESOLVED FIXED

Product:	gnome-clocks
Classification:	Applications
Component:	general
Version:	3.27.x
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	Clocks maintainer(s)
QA Contact:	Clocks maintainer(s)

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2018-02-08 19:30 UTC by Hussam Al-Tayeb
Modified:	2018-02-23 17:28 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Proposed workaround (1.31 KB, patch) 2018-02-21 16:49 UTC, Yanko Kaneti	accepted-commit_now	Details \| Review

Description Hussam Al-Tayeb 2018-02-08 19:30:03 UTC

half the time when searching from gnome-shell for a city, the spawned gnome-clocks process crashes:

+ Trace 238384

Thread 1 (Thread 0x7fdbe9018f40 (LWP 25155))

#0 gweather_location_format_two_serialize
at ../libgweather/gweather-location.c line 1339
#1 gweather_location_serialize
at ../libgweather/gweather-location.c line 1579
#2 clocks_search_provider_serialize_location
at src/gnome-clocks@exe/search-provider.c line 676
#3 __lambda7_
at src/gnome-clocks@exe/search-provider.c line 1063
#4 ___lambda7__gfunc
at src/gnome-clocks@exe/search-provider.c line 1072
#5 g_ptr_array_foreach
at garray.c line 1521
#6 clocks_search_provider_search_locations_co
at src/gnome-clocks@exe/search-provider.c line 1122
#7 g_task_return_now
at gtask.c line 1148
#8 g_task_return
at gtask.c line 1206
#9 clocks_search_provider_search_locations_recurse_co
at src/gnome-clocks@exe/search-provider.c line 940
#10 g_task_return_now
at gtask.c line 1148
#11 g_task_return
at gtask.c line 1206
#12 clocks_search_provider_search_locations_recurse_co
at src/gnome-clocks@exe/search-provider.c line 940
#13 g_task_return_now
at gtask.c line 1148
#14 g_task_return
at gtask.c line 1206
#15 clocks_search_provider_search_locations_recurse_co
at src/gnome-clocks@exe/search-provider.c line 940
#16 g_task_return_now
at gtask.c line 1148
#17 g_task_return
at gtask.c line 1206
#18 clocks_search_provider_search_locations_recurse_co
at src/gnome-clocks@exe/search-provider.c line 940
#19 g_task_return_now
at gtask.c line 1148
#20 g_task_return
at gtask.c line 1206
#21 clocks_search_provider_search_locations_recurse_co
at src/gnome-clocks@exe/search-provider.c line 940
#22 g_task_return_now
at gtask.c line 1148
#23 complete_in_idle_cb
at gtask.c line 1162
#24 g_main_dispatch
at gmain.c line 3177
#25 g_main_context_dispatch
at gmain.c line 3830
#26 g_main_context_iterate
at gmain.c line 3903
#27 g_main_context_iteration
at gmain.c line 3964
#28 g_application_run
at gapplication.c line 2482
#29 _vala_main
at src/gnome-clocks@exe/main.c line 64
#30 main
at src/gnome-clocks@exe/main.c line 74

Comment 1 Hussam Al-Tayeb 2018-02-08 20:20:53 UTC

I don't know how long this has been happening since I don't always look at /var/lib/systemd/coredump/ and there was no visible indication of the crash.
For example, searching for "London" always showed a result regardless of whether there was a crash or not.

Comment 2 Hussam Al-Tayeb 2018-02-09 06:09:44 UTC

dmesg says:

[83492.379192] gnome-clocks[8971]: segfault at 0 ip 00007f493f0a7d7f sp 00007ffeabff85a0 error 4 in libgweather-3.so.15.0.0[7f493f08f000+24000]
[83493.980150] gnome-clocks[9020]: segfault at 0 ip 00007f9e00ccdd7f sp 00007ffd907cb8f0 error 4 in libgweather-3.so.15.0.0[7f9e00cb5000+24000]


So I guess this is due to upgrading from libgweather 3.26 to 3.27.

Comment 3 Yanko Kaneti 2018-02-21 16:49:24 UTC

Created attachment 368722 [details] [review]
Proposed workaround

gweather_location_serialize is currenty not ready to serialize cities
without children weather stations eg: Warangal

Skip those until we either get better serialization handling of those
in libgweather or we change how we produce the data for the search
provider interface

https://bugzilla.redhat.com/show_bug.cgi?id=1546666

Comment 4 Yanko Kaneti 2018-02-21 17:11:56 UTC

https://bugzilla.gnome.org/show_bug.cgi?id=793697 for the libgweather side of the breakage

Comment 5 Paolo Borelli 2018-02-23 15:42:39 UTC

Review of attachment 368722 [details] [review]:

thanks

Comment 6 Yanko Kaneti 2018-02-23 17:28:49 UTC

Pushed to master - commit 9ba5fba