After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793217 - [review] lr/nma-gtk-builder: Port the mobile wizard and VPN password dialog to GtkBuilder
[review] lr/nma-gtk-builder: Port the mobile wizard and VPN password dialog t...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: nm-applet
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Lubomir Rintel
NetworkManager maintainer(s)
Depends on:
Blocks: nm-review
 
 
Reported: 2018-02-06 13:51 UTC by Lubomir Rintel
Modified: 2018-03-14 08:02 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Lubomir Rintel 2018-02-06 13:51:10 UTC
Turning the widget creation declarative essentially makes the bits more maintainable.
Comment 1 Thomas Haller 2018-03-13 11:32:19 UTC
> nma-mobile-wizard: turn into a templated GtkWidget

+typedef struct {
+        GtkAssistant parent;
+} NMAMobileWizard;
+
+typedef struct {
+        GtkAssistantClass parent;
+} NMAMobileWizardClass;


do you expect somebody to subclass these? Otherwise, make them not public API but opaque types.


rest lgtm
Comment 2 Beniamino Galvani 2018-03-13 12:26:11 UTC
Looks good to me.
Comment 3 Lubomir Rintel 2018-03-14 08:02:34 UTC
Merged, with fixup to make NMAMobileWizard and NMAMobileWizardClass not public, as Thomas suggested.