After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793158 - Faulty argument replacement in async begin calls
Faulty argument replacement in async begin calls
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Code Generator: GAsync
0.39.x
Other Linux
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2018-02-04 09:26 UTC by Rico Tzschichholz
Modified: 2018-02-04 10:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
codegen: Don't try to infer error argument on async begin methods (2.30 KB, patch)
2018-02-04 10:07 UTC, Rico Tzschichholz 		committed Details | Review

Description Rico Tzschichholz 2018-02-04 09:26:02 UTC 
async .begin methods do not have error arguments and should not be handled.

This is a regression of https://bugzilla.gnome.org/show_bug.cgi?id=614294

https://git.gnome.org/browse/vala/commit/?id=527dac8050fe90d7a28619383f11e968ab5c9a77
Comment 1 Rico Tzschichholz 2018-02-04 10:07:17 UTC 
Created attachment 367874 [details] [review]
codegen: Don't try to infer error argument on async begin methods

Only the async finish method might have an error parameter.

Regression of 527dac8050fe90d7a28619383f11e968ab5c9a77
Comment 2 Rico Tzschichholz 2018-02-04 10:08:05 UTC 
Attachment 367874 [details] pushed as f53f568 - codegen: Don't try to infer error argument on async begin methods