GNOME Bugzilla – Bug 793105
Cleanup Ubuntu-specific stuff
Last modified: 2018-08-07 20:10:48 UTC
LIBOVERLAY_SCROLLBAR No longer used as of Ubuntu 15.10 for gtk3 (only for gtk2), gtk3's official scrollbar is used instead. Former package overlay-scrollbar-gtk3 used to check for this var. As such, the --enable-distro-packaging option is also useless. No match under /usr on my system using recursive grep, except for /usr/games/sol (Aisleriot) where it was also added by you, Christian :) UBUNTU_MENUPROXY Not sure about this one. A recursive grep matched the package unity-gtk3-module (which I could just remove and apparently causes no change), unity-gtk2-module (obviously should be irrelevant) and unity-services (which ships the binary unity-panel-service which is running for me). No longer setting this variable to 0 seems to result in no change for me. I might easily be missing something, though. NO_UNITY_GTK_MODULE The only Google matches are gnome-terminal and aisleriot, and an ssh log stating that it ignores this unknown variable. I'm wondering if this variable ever did anything anywhere, it was probably introduced by mistake?? (For some strange reason, I cannot see these variables under /proc/<g-t-s>/environ, nor in the shells of my terminals. Why is this? The g_setenv calls are executed.)
(In reply to Egmont Koblinger from comment #0) > LIBOVERLAY_SCROLLBAR > UBUNTU_MENUPROXY I guess these are ok to remove. > NO_UNITY_GTK_MODULE The code that used this on the ubuntu side probably died before being completed. So all of them can go, plus the configure switch.
UBUNTU_MENUPROXY This variable made a difference prior to the GMenu port. If both the unity-gtk3-module package was installed, and this variable was unset / set to 1, then the menu appeared on Unity's panel. If either the package was uninstalled, or the variable was set to 0, the menu appeared inside g-t. This is pretty much what's also expected from the package's description: Description: GtkMenuShell D-Bus exporter This GTK+ 3 module exports GtkMenuShells over D-Bus. Homepage: https://code.launchpad.net/unity-gtk-module (When --app-id was present, the menu sometimes also showed up inside g-t when otherwise I expected it to show up on the Unity panel. I don't know what it depends on.) Beginning with the GMenu port, all this seems to be irrelevant. The menu always shows up on Unity's panel, never inside the g-t window under Unity. There might be some other environment variable forcing the in-window menu, I don't know. So apparently we can safely drop the setting of this variable (or should find its current replacement).
NO_UNITY_GTK_MODULE I'm not sure, but it's a bit suspicious that GTK_MODULES=blah:blah:unity-gtk-module (or lack thereof in the list) is what it's supposed to be. Now here's something broken (from Ubuntu or dbus or whom)?? I click on the g-t icon in the launchbar. GTK_MODULES does contain this entry. In turn, a subsequent server+client with custom --app-id still uses Unity's panel for the menu. I click on the global shortcut Ctrl+Alt+T. GTK_MODULES does not contain this entry, and in turn, a debug server+client with --app-id uses in-window menus. I've removed the relevant code from g-t for this testing, to make sure that it's not NO_UNITY_GTK_MODULE tampering with GTK_MODULES. Again, all these only prior to GMenu; since then it's absolutely always out-of-window Unity menu under Unity.
Created attachment 367777 [details] [review] Fix
Comment on attachment 367777 [details] [review] Fix Committed.
Did you peak with Ubuntu devs before removing this? This in turn causes Alt+F, Alt+E not working when using indicator-appmenu(global_menu) in either Unity or gnome-flashback session.
I don't think _this_ issue is related. It's the change of bug 792978 causing these not to work.
Err, sorry, I meant the change of bug 745329: the GMenu port.