GNOME Bugzilla – Bug 793101
Notes lost their titles
Last modified: 2018-02-06 23:26:26 UTC
Created attachment 367768 [details] Screenshot of notes without titles I had 3 notes in Bijiben, and two of them lost their titles. I was playing with the application, switching back and forth between the grid and list views, trying the selection mode, etc.. After restarting the application for the Nth time, I saw that two of my notes no longer have a title. This happens in both the list and grid views. The notes still have their contents, though. If I open them, the entire text is still there.
Created attachment 367933 [details] [review] webkit-editor: Fix title saving When you have only one line in a note, Notes should use that as title, but it only considers a title when it has at least two. This patch changes that, so Notes will start to consider a note to have at least 1 line for saving.
Review of attachment 367933 [details] [review]: I don't see any change with the code (I can't reproduce the bug). But the patch logic looks good. You may also update the preceding comment "g_strv_length (rows) > 1" to "g_strv_length (rows) > 0". Also, deleting the blank line just after this comment may also be good. Please push to master.
Created attachment 367951 [details] Tarred .local/share/bijiben/
Attached a tarball of my ~/.local/share/bijiben. Maybe that will shed some light on this issue? Thanks a lot for looking into this!
Created attachment 367967 [details] [review] webkit-editor: Fix saving title When you have only one line in a note, Notes should use that as title, but it only considers a title when it has at least two. This patch changes that, so Notes will start to consider a note to have at least 1 line for saving.
Review of attachment 367933 [details] [review]: obsolete
Review of attachment 367967 [details] [review]: (In reply to Mohammed Sadiq from comment #2) > Review of attachment 367933 [details] [review] [review]: > You may also update the preceding comment "g_strv_length (rows) > 1" to > "g_strv_length (rows) > 0". Done. > Also, deleting the blank line just after this comment may also be good. Done. > Please push to master. Done. And I also changed the title as you suggested by chat. Thanks for your review!
(In reply to Debarshi Ray from comment #4) > Attached a tarball of my ~/.local/share/bijiben. Maybe that will shed some > light on this issue? Thanks for sharing that. I've used your notes to test. After applying the patch above, I was able to save your notes nicely.
*** Bug 793093 has been marked as a duplicate of this bug. ***