After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793089 - Documentation for default ::keynav-failed handler is incorrect.
Documentation for default ::keynav-failed handler is incorrect.
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Documentation
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2018-02-01 12:28 UTC by Tomasz Miąsko
Modified: 2018-03-29 18:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix documentation for default ::keynav-failed handler. (1.04 KB, patch)
2018-02-01 12:28 UTC, Tomasz Miąsko
none Details | Review
Widget: Fix doc of default ::keynav-failed handler (1.09 KB, patch)
2018-03-14 12:10 UTC, Daniel Boles
committed Details | Review

Description Tomasz Miąsko 2018-02-01 12:28:56 UTC
Created attachment 367751 [details] [review]
Fix documentation for default ::keynav-failed handler.

The documentation for default handler of ::keynav-failed describes it as follows:

 * The default ::keynav-failed handler returns %TRUE for
 * %GTK_DIR_TAB_FORWARD and %GTK_DIR_TAB_BACKWARD. For the other
 * values of #GtkDirectionType it returns %FALSE.

In fact, the return value of a default handler is exactly the opposite. You
can find a patch attached (made against gtk-3-22, the same issue applies
to master).
Comment 1 Daniel Boles 2018-03-12 21:57:05 UTC
Comment on attachment 367751 [details] [review]
Fix documentation for default ::keynav-failed handler.

Yup, this makes the docs match the code, which was last touched in 2006, so it seems like a no-brainer.
Comment 2 Daniel Boles 2018-03-14 12:10:06 UTC
Created attachment 369667 [details] [review]
Widget: Fix doc of default ::keynav-failed handler

I fit the shortlog in 50 characters and added the link to this bug. I'll probably push this later.
Comment 3 Daniel Boles 2018-03-29 18:20:40 UTC
Attachment 369667 [details] pushed as 56d44fd - Widget: Fix doc of default ::keynav-failed handler