After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792934 - build: Add flatpak manifest
build: Add flatpak manifest
Status: RESOLVED FIXED
Product: bijiben
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Bijiben maintainer(s)
Bijiben maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2018-01-26 15:34 UTC by Mohammed Sadiq
Modified: 2018-01-26 18:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Add flatpak manifest (5.18 KB, patch)
2018-01-26 15:34 UTC, Mohammed Sadiq 		none Details | Review
build: Add flatpak manifest (5.11 KB, patch)
2018-01-26 17:55 UTC, Mohammed Sadiq 		none Details | Review
build: Add flatpak manifest (5.17 KB, patch)
2018-01-26 18:20 UTC, Mohammed Sadiq 		committed Details | Review

Description Mohammed Sadiq 2018-01-26 15:34:12 UTC 
.
Comment 1 Mohammed Sadiq 2018-01-26 15:34:18 UTC 
Created attachment 367483 [details] [review]
build: Add flatpak manifest
Comment 2 Isaque Galdino 2018-01-26 17:28:07 UTC 
Review of attachment 367483 [details] [review]:

> build-aux/flatpak/org.gnome.bijiben.json | 126 +++++++++++++++++++++++++++++++
> 1 file changed, 126 insertions(+)
> create mode 100644 build-aux/flatpak/org.gnome.bijiben.json
Any reason for this file to be in build-aux? why not app root or data?

> +        "--talk-name=org.gnome.ControlCenter",
I don't think we need that.

> +            "buildsystem": "cmake",
> +            "cmake": true,
buildsystem property is already set to cmake, do we need to explicitly set cmake as well?

Thanks.
Comment 3 Mohammed Sadiq 2018-01-26 17:55:49 UTC 
Created attachment 367488 [details] [review]
build: Add flatpak manifest

> Any reason for this file to be in build-aux? why not app root or data?
I followed the style of gnome-builder and nautilus
Comment 4 Mohammed Sadiq 2018-01-26 18:20:33 UTC 
Created attachment 367489 [details] [review]
build: Add flatpak manifest
Comment 5 Isaque Galdino 2018-01-26 18:30:53 UTC 
Review of attachment 367489 [details] [review]:

lgtm
Comment 6 Isaque Galdino 2018-01-26 18:31:57 UTC 
Attachment 367489 [details] pushed as 8a3dc10 - build: Add flatpak manifest