After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792919 - Make ALSA support optional
Make ALSA support optional
Status: RESOLVED FIXED
Product: libgnome-volume-control
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: libgnome-volume-control-maint
libgnome-volume-control-maint
Depends on:
Blocks:
 
 
Reported: 2018-01-26 09:08 UTC by Iñigo Martínez
Modified: 2018-01-26 10:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Make ALSA support optional (2.52 KB, patch)
2018-01-26 09:09 UTC, Iñigo Martínez 		committed Details | Review

Description Iñigo Martínez 2018-01-26 09:08:17 UTC 
ALSA support is not mandatory for libgnome-volume-control, but it can not be made optional.
Comment 1 Iñigo Martínez 2018-01-26 09:09:13 UTC 
Created attachment 367459 [details] [review]
build: Make ALSA support optional

This patch makes the ALSA support optional by using an option.
Comment 2 Bastien Nocera 2018-01-26 09:37:02 UTC 
Review of attachment 367459 [details] [review]:

Is it possible to pass that information down from the meson.build that uses libgvc as a submodule?

For example, gnome-settings-daemon requires this option on Linux systems, not on others, neither gnome-shell nor gnome-control-center require it (it's in fact, not useful at all there).
Comment 3 Iñigo Martínez 2018-01-26 09:46:54 UTC 
(In reply to Bastien Nocera from comment #2)
> Review of attachment 367459 [details] [review] [review]:
> 
> Is it possible to pass that information down from the meson.build that uses
> libgvc as a submodule?

Yes, by using the `default_options` parameter in the `subproject` function. For example:

libgvc = subproject(
  'gvc',
  default_options: [
    'static=true',
    'alsa=false,
  ]
)

> For example, gnome-settings-daemon requires this option on Linux systems,
> not on others, neither gnome-shell nor gnome-control-center require it (it's
> in fact, not useful at all there).

Actually, I have made this patch just for `gnome-settings-daemon`, that can disable ALSA on non linux platforms.

The default value of the option is true, so those packages will have the same behaviour regardless of this change.
Comment 4 Iñigo Martínez 2018-01-26 09:50:18 UTC 
Comment on attachment 367459 [details] [review]
build: Make ALSA support optional

Pushed as 67533bf - build: Make ALSA support optional
Comment 5 Bastien Nocera 2018-01-26 09:52:00 UTC 
(In reply to Iñigo Martínez from comment #3)
> (In reply to Bastien Nocera from comment #2)
> > Review of attachment 367459 [details] [review] [review] [review]:
> > 
> > Is it possible to pass that information down from the meson.build that uses
> > libgvc as a submodule?
> 
> Yes, by using the `default_options` parameter in the `subproject` function.
> For example:
> 
> libgvc = subproject(
>   'gvc',
>   default_options: [
>     'static=true',
>     'alsa=false,
>   ]
> )

Great, very useful.

> > For example, gnome-settings-daemon requires this option on Linux systems,
> > not on others, neither gnome-shell nor gnome-control-center require it (it's
> > in fact, not useful at all there).
> 
> Actually, I have made this patch just for `gnome-settings-daemon`, that can
> disable ALSA on non linux platforms.
> 
> The default value of the option is true, so those packages will have the
> same behaviour regardless of this change.

Well, we don't want true on those, as alsa is not required for those modules, and unusable on non-Linux.

I'll try to update gnome-control-center and gnome-shell for that.