Created attachment 367215 [details] [review]
directsoundsink: Add support for a DeviceProvider

Created attachment 367216 [details] [review]
directsoundsrc: Add support for a DeviceProvider

Created attachment 367389 [details] [review]
directsoundsink: Add support for a DeviceProvider

Created attachment 367390 [details] [review]
directsoundsrc: Add support for a DeviceProvider

Review of attachment 367389 [details] [review]:

LGTM, just a few minor comments.

::: sys/directsound/gstdirectsounddevice.c
@@ +103,3 @@
+      "audio/x-ac3, framed = (boolean) true;"
+      "audio/x-dts, framed = (boolean) true;");
+#endif

Maybe it makes sense to factor this out into gstdirectsoundsink.h as a string macro instead of duplicating it? Ditto for gstdirectsoundsrc.h.

@@ +124,3 @@
+  GST_INFO_OBJECT (probe_data->self, "sound device name: %s, %s (GUID %s)",
+      description, driver, guid_str);
+

GST_STR_NULL (guid_str) ?

@@ +140,3 @@
+      "device-class", "Audio/Sink", "properties", props, NULL);
+#endif
+

If you want to be fancy, you can #ifdef only "Audio/Source" and "Audio/Sink" ;)

Created attachment 367434 [details] [review]
directsoundsrc: Add support for a DeviceProvider

Created attachment 367435 [details] [review]
directsoundsrc: Add support for a DeviceProvider

Created attachment 367437 [details] [review]
directsoundsink: Add support for a DeviceProvider

(In reply to Nirbheek Chauhan from comment #5)

> @@ +140,3 @@
> +      "device-class", "Audio/Sink", "properties", props, NULL);
> +#endif
> +
> 
> If you want to be fancy, you can #ifdef only "Audio/Source" and "Audio/Sink"
> ;)

No, MSVC is usually unhappy about such things :)

Comment on attachment 367435 [details] [review]
directsoundsrc: Add support for a DeviceProvider

Attachment 367435 [details] pushed as b174a91 - directsoundsrc: Add support for a DeviceProvider

Attachment 367437 [details] pushed as b5364f9 - directsoundsink: Add support for a DeviceProvider

(In reply to Sebastian Dröge (slomo) from comment #9)
> (In reply to Nirbheek Chauhan from comment #5)
> 
> > @@ +140,3 @@
> > +      "device-class", "Audio/Sink", "properties", props, NULL);
> > +#endif
> > +
> > 
> > If you want to be fancy, you can #ifdef only "Audio/Source" and "Audio/Sink"
> > ;)
> 
> No, MSVC is usually unhappy about such things :)

MSVC is only unhappy if you nest #ifdefs inside a macro definition (the pre-processor is not recursive). It doesn't mind #ifdef inside a function call.