After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792636 - To make display VS(variation sequences. SVS/IVS/FVS) on gnome-terminal
To make display VS(variation sequences. SVS/IVS/FVS) on gnome-terminal
Status: RESOLVED OBSOLETE
Product: pango
Classification: Platform
Component: general
1.41.x
Other Linux
: Normal normal
: ---
Assigned To: pango-maint
pango-maint
Depends on:
Blocks:
 
 
Reported: 2018-01-18 09:03 UTC by Akira Nakajima
Modified: 2018-05-22 13:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
To make display VS(variation sequences. SVS/IVS/FVS) on gnome-terminal (10.58 KB, text/plain)
2018-01-18 09:03 UTC, Akira Nakajima
  Details
To-make-display-VS-variation-sequence-SVS-IVS-FVS (10.58 KB, patch)
2018-01-19 07:57 UTC, Akira Nakajima
none Details | Review
Sample text U+9089 (1.69 KB, application/mbox)
2018-01-23 02:26 UTC, Akira Nakajima
  Details
Sample text U+9089 (643.00 KB, application/x-tar)
2018-01-23 02:29 UTC, Akira Nakajima
  Details

Description Akira Nakajima 2018-01-18 09:03:46 UTC
Created attachment 366996 [details]
To make display VS(variation sequences. SVS/IVS/FVS) on gnome-terminal

My purpose is to make display VS(variation sequences. SVS/IVS/FVS) on gnome-terminal and gedit at RHEL/CentOS.
Now these application show only base character.

To fix completely, it is necessary to modify many libraries.
 (vte-2.91, pango, harfbuzz, freetype2, fontconfig, GLib, etc.)
It's very hard work.

So I created a patch with a minimal amount of modifications.
Such patch maybe not acceptable from the view point of libraries.
Please tell us your opinion.



After applying this patch, I know following problem.

When scroll up/resize/maximize window of vte-2.91 and gnome-terminal, 
 VS characters will change to only base character.
I think need patch of vte-2.91, and now creating such patch.
Comment 1 Peng Wu 2018-01-19 06:00:50 UTC
Could you write the patch on Fedora 27 or later version?

The pango version in Fedora 27 is more updated.
Comment 2 Akira Nakajima 2018-01-19 07:57:13 UTC
Created attachment 367056 [details] [review]
To-make-display-VS-variation-sequence-SVS-IVS-FVS

I reposted patch based on pango 1.41.0.

I tested at
pango  1.41.0
harfbuzz  1.7.4
vte-2.91  0.51.3
gnome-terminal  3.27.4
Fedora 27
Comment 3 Peng Wu 2018-01-22 05:39:41 UTC
Could you provides some test examples for gedit?

I plan to check the current status of gedit for VS.
Comment 4 Akira Nakajima 2018-01-23 02:26:16 UTC
Created attachment 367272 [details]
Sample text U+9089

This is sample UTF-8 text of
 U+9089, U+9089+E0100 - U+9089+E010F.

Need VS font at /usr/share/fonts/ (in case of Fedora).

Attached picture is tested by SourceHanSans font.
SourceHanSans has U+9089+E0100 - U+9089+E010E
 but does not have U+9089+E010F.


01.png
When display U+9080+E010F, it shows only base character.


02_with_modified_harfbuzz.png
When display U+9089+E010F with modified harfbuzz
 , display U+9089 base character + E010F.
I attach patch of harfbuzz.


Note:
 For display VS on FireFox, set font to SourceHanSans (=源の角ゴシック).
Comment 5 Akira Nakajima 2018-01-23 02:29:11 UTC
Created attachment 367273 [details]
Sample text U+9089
Comment 6 Akira Nakajima 2018-03-13 00:55:06 UTC
Example works correctly?
FireFox displays correctly SVS/IVS, so we can check display SVS/IVS on GNOME-terminal/gedit by comparing with FireFox.


Will such a temporary substitute patch be accepted?
If you can accept, I will make patch of vte-2.91 about this problem.

> When scroll up/resize/maximize window of vte-2.91 and gnome-terminal, 
> VS characters will change to only base character.


P.S.
FVS (Mongolian) works not properly.
In the first place, Mongolian characters can not be displayed properly at GNOME-Terminal.
 (gedit works correctly.)
So temporarily I drop out FVS support.
Comment 7 GNOME Infrastructure Team 2018-05-22 13:29:46 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/pango/issues/297.