After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792486 - typefindhelper: fix confusing log in helper_find_peek
typefindhelper: fix confusing log in helper_find_peek
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal minor
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-01-13 02:40 UTC by Jun Xie
Modified: 2018-01-15 16:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Distinguish two types of buffer for clear log (1.66 KB, patch)
2018-01-13 02:42 UTC, Jun Xie 		committed Details | Review

Description Jun Xie 2018-01-13 02:40:24 UTC 
at then end of file, requested buffer size may not be fulfilled.
In case of shorten buffer size, the log is quite confusing.
>default gsttypefindhelper.c:177:helper_find_peek:[00m dropping short buffer: 18446744073709551615-429 instead of 18162-22257
Comment 1 Jun Xie 2018-01-13 02:42:43 UTC 
Created attachment 366756 [details] [review]
Distinguish two types of buffer for clear log
Comment 2 Tim-Philipp Müller 2018-01-15 16:36:53 UTC 
Thanks for the patch. I have pushed it with a few changes (moved the size check up so it's closer to the comment; changed the debug messages and simplified the wrong offset debug message).

commit 33e7269c37986f6df40db0e5090e77d57a2da218 (HEAD -> master)
Author: Jun Xie <jun.xie@samsung.com>
Date:   Sat Jan 13 11:08:00 2018 +0800

    typefindhelper: fix confusing debug log message
    
    In case of a short buffer, the debug log is quite confusing.
    Distinguish the two types of failure cases to make it clearer.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=792486