After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792304 - wnck_set_client_type should silently ignore attempts to the the same client type again.
wnck_set_client_type should silently ignore attempts to the the same client t...
Status: RESOLVED FIXED
Product: libwnck
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: libwnck maintainers
libwnck maintainers
Depends on:
Blocks:
 
 
Reported: 2018-01-07 17:50 UTC by Sebastian
Modified: 2018-01-10 03:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
util: allow setting the same client type again (1.44 KB, patch)
2018-01-07 17:50 UTC, Sebastian 		committed Details | Review
util: allow setting the same client type again (1.44 KB, patch)
2018-01-10 03:25 UTC, Marco Trevisan (Treviño) 		committed Details | Review

Description Sebastian 2018-01-07 17:50:16 UTC 
We should relax the critical warning when the client type is set and only emit it is the user tries to set a different client type. An attempt to set the same client type again should be silently ignored. This makes it easier in cases where multiple parts in the program that need to set the same client type because we do not need to check if it has already been set.
Comment 1 Sebastian 2018-01-07 17:50:44 UTC 
Created attachment 366461 [details] [review]
util: allow setting the same client type again
Comment 2 Marco Trevisan (Treviño) 2018-01-10 03:25:28 UTC 
The following fix has been pushed:
commit 16cda4b util: allow setting the same client type again
Comment 3 Marco Trevisan (Treviño) 2018-01-10 03:25:35 UTC 
Created attachment 366583 [details] [review]
util: allow setting the same client type again