After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792282 - gtk4 hard-codes the prefix of iso-codes in gtk/language-names.c and demos/gtk-demo/language-names.c
gtk4 hard-codes the prefix of iso-codes in gtk/language-names.c and demos/gtk...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
3.93.x
Other FreeBSD
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2018-01-06 19:39 UTC by Ting-Wei Lan
Modified: 2018-01-07 06:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Use pkg-config to find iso-codes (2.52 KB, patch)
2018-01-06 19:43 UTC, Ting-Wei Lan 		committed Details | Review

Description Ting-Wei Lan 2018-01-06 19:39:07 UTC 
Both gtk/language-names.c and demos/gtk-demo/language-names.c hard-code ISO_CODES_PREFIX to /usr, and it causes warning messages to show on the terminal on FreeBSD because iso-codes can never be installed to /usr. FreeBSD ports use /usr/local as prefix by default.

iso-codes package provides a .pc file, so we can easily know the prefix by running 'pkg-config --variable=prefix iso-codes'.
Comment 1 Ting-Wei Lan 2018-01-06 19:43:34 UTC 
Created attachment 366432 [details] [review]
build: Use pkg-config to find iso-codes

Instead of hard-coding the path of iso-codes, we can get the prefix with
pkg-config. We still fallback to /usr when it is not available.
Comment 2 Emmanuele Bassi (:ebassi) 2018-01-06 22:15:26 UTC 
Review of attachment 366432 [details] [review]:

Looks good to me
Comment 3 Ting-Wei Lan 2018-01-07 06:57:23 UTC 
Attachment 366432 [details] pushed as 14b181e - build: Use pkg-config to find iso-codes