GNOME Bugzilla – Bug 792152
With Adwaita Dark, get light text on light background for expanded multi-line entries
Last modified: 2018-02-01 14:40:13 UTC
Created attachment 366239 [details] The light-on-light text entries. When using the Adwaita Dark GTK theme, any multi-line log message that has been expanded appears with light text on a light background, making it difficult to read. See the screenshot for an example. This likely means that the colour of either the text or the background is hard-coded instead of using a colour inherited from the current GTK theme.
Thanks for the report. Issue confirmed. (In reply to krinkodot22 from comment #0) > This likely means that the colour of either the text or the background is > hard-coded instead of using a colour inherited from the current GTK theme. You are right. The colour is hard-coded atm. The dark variant theme wasn't considered while implementing this.
Please fix this in 3.28 atleast, I've hit this too. It's annoying af.
@Jakub Could you please help with this one providing a colour schema that works in terms of different themes? Thanks.
Created attachment 367678 [details] [review] theme: avoid using hard-coded colors - Have include a bit of a rant. This is actually bad. We are back at focusing on themes. Adwaita dark wasn't meant to be a global theme users can opt in. It was meant to be for application to opt in. Here we are again, wasting cycles on making things work for X themes rather than doing something useful. Like flapjack. Having an easy to use development environment.
Created attachment 367679 [details] [review] theme: avoid using hard-coded colors Use share operations instead of hardcoded colors to make it work on Adwaita-dark.
Comment on attachment 367679 [details] [review] theme: avoid using hard-coded colors Looks good. Thanks for the patch. I've pushed it to master as commit 0968474564d8bb114b05b69e914606455539ef1b and gnome-3-26 as commit c4d29e4c0294962e7cbc43ba37d0ea7a23dfd01d.
I'll release 3.26.3 for this issue. Close this as RESOLVED FIXED.