After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792129 - meson: skip optional linux/unix deps that default to true when building on Windows
meson: skip optional linux/unix deps that default to true when building on Wi...
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: build
unspecified
Other Windows
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks: 790954
 
 
Reported: 2018-01-02 15:32 UTC by Tim-Philipp Müller
Modified: 2018-01-07 12:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
meson: skip optional linux/unix deps that default to true when building on Windows (1.78 KB, patch)
2018-01-02 15:32 UTC, Tim-Philipp Müller 		none Details | Review
meson: skip optional linux deps that default to true when building on Windows (v2) (1.84 KB, patch)
2018-01-07 12:08 UTC, Tim-Philipp Müller 		committed Details | Review

Description Tim-Philipp Müller 2018-01-02 15:32:57 UTC 
Created attachment 366204 [details] [review]
meson: skip optional linux/unix deps that default to true when building on Windows

This is a result of getting rid of 'auto' options.

It seems a bit silly that one should have to specify -Dselinux=false when building for Windows.
Comment 1 Christoph Reiter (lazka) 2018-01-04 05:35:39 UTC 
Review of attachment 366204 [details] [review]:

lgtm. I tested this under msys2

Is libmount available on macOS?
Comment 2 Emmanuele Bassi (:ebassi) 2018-01-05 14:36:57 UTC 
(In reply to Christoph Reiter (lazka) from comment #1)
> Review of attachment 366204 [details] [review] [review]:
> 
> lgtm. I tested this under msys2
> 
> Is libmount available on macOS?

No, libmount is Linux-only, as far as I know.
Comment 3 Emmanuele Bassi (:ebassi) 2018-01-05 14:38:36 UTC 
Review of attachment 366204 [details] [review]:

::: meson.build
@@ +1505,3 @@
 # pkg-config file below
 libmount_dep = []
+if get_option('libmount') and host_system != 'windows'

I'd flip around the conditions:

  if host_system != 'windows' and get_option('libmount')

here and below; in this case, I'd also check for `linux`, because libmount is Linux-only as far as I know.
Comment 4 Tim-Philipp Müller 2018-01-07 12:08:11 UTC 
Created attachment 366452 [details] [review]
meson: skip optional linux deps that default to true when building on Windows (v2)
Comment 5 Tim-Philipp Müller 2018-01-07 12:09:24 UTC 
Comment on attachment 366452 [details] [review]
meson: skip optional linux deps that default to true when building on Windows (v2)

Pushed as commit 7c8906dcdabf30ac248e0f6838f71a3af9645aa5