GNOME Bugzilla – Bug 792040
omxvideodec: add hack to pass color format from caps to OMX decoder
Last modified: 2018-01-30 09:33:13 UTC
Use the extra info from the caps parser (bug #792039) and pass them to OMX.
Created attachment 366072 [details] [review] omxvideodec: add hack to pass color format from caps to OMX decoder This hack tries to pass as much information as possible from caps to the decoder before it receives any buffer. These information can be used by the OMX decoder to, for example, pre-allocate its internal buffers before starting to decode and so reduce its initial latency. This mechanism is currently supported by the zynqultrascaleplus decoder.
Created attachment 366073 [details] [review] omxvideoenc: factor out get_output_caps() No semantic change so far.
Created attachment 366074 [details] [review] omxvideoenc: expose chroma format and bit depth in output caps As we added in the parser (bgo#792039) expose the chroma and bit depth information in output caps.
Review of attachment 366072 [details] [review]: Good.
Review of attachment 366074 [details] [review]: ::: omx/gstomxvideoenc.c @@ +570,3 @@ + *bit_depth_luma = *bit_depth_chroma = 8; + break; +#if 0 Caugh ... Caugh ...
Review of attachment 366073 [details] [review]: Correct, it does not mention, but it's to support next patch, will merge when the next patch is fixed.
(In reply to Nicolas Dufresne (stormer) from comment #5) > Review of attachment 366074 [details] [review] [review]: > > ::: omx/gstomxvideoenc.c > @@ +570,3 @@ > + *bit_depth_luma = *bit_depth_chroma = 8; > + break; > +#if 0 > > Caugh ... Caugh ... I removed the #if 0 now that the 10 bits formats have been merged to base.
Created attachment 367615 [details] [review] omxvideodec: add hack to pass color format from caps to OMX decoder This hack tries to pass as much information as possible from caps to the decoder before it receives any buffer. These information can be used by the OMX decoder to, for example, pre-allocate its internal buffers before starting to decode and so reduce its initial latency. This mechanism is currently supported by the zynqultrascaleplus decoder.
Created attachment 367616 [details] [review] omxvideoenc: factor out get_output_caps() No semantic change so far.
Created attachment 367617 [details] [review] omxvideoenc: expose chroma format and bit depth in output caps As we added in the parser (bgo#792039) expose the chroma and bit depth information in output caps.
Attachment 367615 [details] pushed as 2ca3cf5 - omxvideodec: add hack to pass color format from caps to OMX decoder Attachment 367616 [details] pushed as 1990580 - omxvideoenc: factor out get_output_caps() Attachment 367617 [details] pushed as 6c57d06 - omxvideoenc: expose chroma format and bit depth in output caps