After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791982 - player: critical warnings in audio,video,subtitle property getters
player: critical warnings in audio,video,subtitle property getters
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Mac OS
: Normal normal
: 1.12.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-12-27 13:14 UTC by Philippe Normand
Modified: 2017-12-27 15:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (2.05 KB, patch)
2017-12-27 13:15 UTC, Philippe Normand 		none Details | Review
updated patch (1.85 KB, patch)
2017-12-27 14:57 UTC, Philippe Normand 		accepted-commit_now Details | Review

Description Philippe Normand 2017-12-27 13:14:19 UTC 
See commit message.
Comment 1 Philippe Normand 2017-12-27 13:15:19 UTC 
Created attachment 366013 [details] [review]
proposed patch
Comment 2 Tim-Philipp Müller 2017-12-27 14:26:03 UTC 
Comment on attachment 366013 [details] [review]
proposed patch

Looks correct, but wouldn't be nicer and shorter to just use g_value_take_object() instead?
Comment 3 Philippe Normand 2017-12-27 14:43:14 UTC 
Yes indeed, now that you mention it :)
Comment 4 Philippe Normand 2017-12-27 14:57:30 UTC 
Created attachment 366018 [details] [review]
updated patch
Comment 5 Philippe Normand 2017-12-27 15:31:01 UTC 
Thanks, I can also push in 1.12 if a new release is planned soon for that branch?

commit 13363f2388a511c6fb0df18eabce7a13f36c1773 (HEAD -> master)
Author: Philippe Normand <philn@igalia.com>
Date:   Wed Dec 27 13:08:18 2017 +0000

    player: transfer ownership of info properties
    
    The previous code would emit GObject critical warnings when the info properties
    are NULL.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=791982
Comment 6 Tim-Philipp Müller 2017-12-27 15:45:54 UTC 
I don't know if there's a plan, but might just as well pick it into 1.12 anyway.