GNOME Bugzilla – Bug 791932
Tests not deterministic
Last modified: 2021-06-18 10:40:46 UTC
Tests sometimes fail and sometimes run okay. In one build build https://hydra.nixos.org/build/66446594#tabs-summary there was this failure. ** (./test-data-der:15412): CRITICAL **: egg_symkey_generate_pkcs12: assertion 'iterations > 0' failed FAIL: test-data-der 16 /gkm/data-der/write_pkcs8_encrypted ERROR: test-data-der process failed: 251 In other I saw: ERROR:pkcs11/gkm/test-timer.c:97:test_cancel: assertion failed: (timer != NULL) FAIL: test-timer 3 /gkm/timer/cancel That one is also mentioned in https://bugzilla.gnome.org/show_bug.cgi?id=754633
Created attachment 369150 [details] [review] gkm-timer: Use monotonic time exclusively Previously, it used g_get_real_time(), g_get_current_time(), and g_get_monotonic_time() in a mixed manner. To measure the ellapsed time, it would be sufficient to use g_get_monotonic_time() only. -- When I see the test-timer failure, I observe a strange time jump in g_get_real_time() in timer_thread_func(). I am not sure why this happens, but using monotonic time instead should fix the issue.
Comment on attachment 369150 [details] [review] gkm-timer: Use monotonic time exclusively Attachment 369150 [details] pushed as 1864f1e - gkm-timer: Use monotonic time exclusively
For reference, the first FAIL is still happening with 3.28.2: https://nix-cache.s3.amazonaws.com/log/hk2zp7my151ncl3axdd9q2vprp5422af-gnome-keyring-3.28.2.drv
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new ticket at https://gitlab.gnome.org/GNOME/gnome-keyring/-/issues/ Thank you for your understanding and your help.