After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791833 - waveparse: Assert and execute an integer overflow on invalid duration
waveparse: Assert and execute an integer overflow on invalid duration
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal minor
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 791811
Blocks:
 
 
Reported: 2017-12-21 03:39 UTC by Nicolas Dufresne (ndufresne)
Modified: 2018-11-03 15:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Nicolas Dufresne (ndufresne) 2017-12-21 03:39:17 UTC 
+++ This bug was initially created as a clone of Bug #791811 +++

A bug in festival element lead to this assertion:

ERROR:gstwavparse.c:1310:gst_wavparse_stream_headers: assertion failed: (upstream_size >= wav->offset)

I think it's a bit silly to assert and compute the integer overflow. We should warn and ignore the duration query value instead.
Comment 1 Sebastian Dröge (slomo) 2017-12-21 09:55:16 UTC 
upstream_size comes from a duration query, wav->offset is the position from where we pulled just before in pull mode, and the byte counter from the adapter otherwise.

While I agree that this should not assert, it seems like something else is off too here. Either we failed counting bytes, upstream allows to pull from after the duration, or upstream reports completely bogus duration, or the state variables in wavparse became inconsistent.
Comment 2 Nicolas Dufresne (ndufresne) 2017-12-21 13:41:14 UTC 
See 791811, the bug I have cloned this from. It explains everything about why the duration query is bogus and why this will happen again. I'm filling this to fix the integer overflow because it's not predictable. Marking as minor to reflect this.
Comment 3 GStreamer system administrator 2018-11-03 15:24:55 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/427.