After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791775 - Rework notifications
Rework notifications
Status: RESOLVED OBSOLETE
Product: dconf-editor
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: dconf-editor maintainer(s)
dconf-editor maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-12-19 09:49 UTC by Arnaud B.
Modified: 2019-03-20 10:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Davi’s patch from bug 731750. (6.65 KB, patch)
2017-12-19 09:49 UTC, Arnaud B.
none Details | Review
Fix order change confused as content change (2.99 KB, patch)
2017-12-19 17:10 UTC, Davi
committed Details | Review

Description Arnaud B. 2017-12-19 09:49:03 UTC
Created attachment 365736 [details] [review]
Davi’s patch from bug 731750.

The user should be clearly understanding what’s happening when it is asked, for example, to reload the view. So we should have enough messages to cover all the cases, and the most important message should be always displayed until activation (or view change).

Also, there’s currently a bug where doing:
  gsettings set ca.desrt.dconf-editor.Settings sort-folders \'first\'
  gsettings set ca.desrt.dconf-editor.Settings sort-folders \'mixed\'
  gsettings set ca.desrt.dconf-editor.Settings sort-folders \'first\'
  gsettings set ca.desrt.dconf-editor.Settings sort-folders \'mixed\'
changes the notification displayed.
Comment 1 Davi 2017-12-19 17:10:03 UTC
Created attachment 365752 [details] [review]
Fix order change confused as content change

The bug showed my assumption about the order was invalid, so I changed to a O(n²) all-against-all check. If it gets too slow for very large folders, we can come up with some better solution.
Comment 2 Arnaud B. 2017-12-19 22:50:18 UTC
Comment on attachment 365752 [details] [review]
Fix order change confused as content change

(In reply to Davi from comment #1)
> The bug showed my assumption about the order was invalid, so I changed to a
> O(n²) all-against-all check. If it gets too slow for very large folders, we
> can come up with some better solution.

Thanks! it’s committed. I don’t think the speed will be a really big problem; Dconf Editor has been slow as hell during three cycles and nobody complained. ^^’
Comment 3 GNOME Infrastructure Team 2019-03-20 10:40:58 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/dconf-editor/issues/27.