After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791772 - Meson build fix for windows opengl support
Meson build fix for windows opengl support
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
1.12.4
Other Windows
: Normal critical
: 1.12.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-12-19 07:47 UTC by Roland Peffer
Modified: 2018-01-16 14:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
diff file with fix (601 bytes, patch)
2017-12-19 07:47 UTC, Roland Peffer 		committed Details | Review

Description Roland Peffer 2017-12-19 07:47:38 UTC 
Created attachment 365734 [details] [review]
diff file with fix

fixed: gst-plugins-bad-1.12.4\gst-libs\gst\gl\meson.build 

When building gst-plugins-bad 1.12.4 on Windows with meson, the gstglconfig.h is not initialized correctly. Also win32/gstglcontext_wgl.c is not included.

Here is the patch to fix that:

+++ .\gstreamer\gst-plugins-bad-1.12.4\gst-libs\gst\gl\meson.build       2017-12-19 08:30:36 +0100
@@ -549,10 +549,13 @@
       'win32/win32_message_source.c',
       'win32/gstglwindow_win32.c',
       'win32/gstglwindow_win32.c',
+      'win32/gstglcontext_wgl.c',
     ]
     enabled_gl_winsys += 'win32'
     gl_winsys_deps += gdi_dep
     enabled_gl_platforms += 'wgl'
+    glconf.set10('GST_GL_HAVE_WINDOW_WIN32', 1)
+    glconf.set10('GST_GL_HAVE_PLATFORM_WGL', 1)
   endif
 endif
Comment 1 Tim-Philipp Müller 2018-01-16 14:00:17 UTC 
Thanks, pushed (but changed the .set10() to .set() here):

commit 0ffc2015aaabbce918b6965eef02704eb7755ef0 (HEAD -> master)
Author: Roland Peffer <gdevel@clixxun.com>
Date:   Tue Jan 16 13:59:08 2018 +0000

    meson: gl: fix build on windows
    
    https://bugzilla.gnome.org/show_bug.cgi?id=791772
Comment 2 Tim-Philipp Müller 2018-01-16 14:09:07 UTC 
Comment on attachment 365734 [details] [review]
diff file with fix

Would be great if you could provide a patch in 'git format-patch' format next time, that saves us typing in author details and a commit message :)