After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791655 - background: don't leak wall clock when background changes
background: don't leak wall clock when background changes
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2017-12-15 15:12 UTC by Ray Strode [halfline]
Modified: 2017-12-15 15:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
background: don't leak wall clock when background changes (2.64 KB, patch)
2017-12-15 15:12 UTC, Ray Strode [halfline] 		committed Details | Review

Description Ray Strode [halfline] 2017-12-15 15:12:48 UTC 
The background code allocates a GnomeWallClock when its first created,
but neglects to drop a reference to that clock at destroy time.
The undestroyed clocks lead to a timerfd leak that eventually prevents
the shell from functioning.
Comment 1 Ray Strode [halfline] 2017-12-15 15:12:55 UTC 
Created attachment 365590 [details] [review]
background: don't leak wall clock when background changes
Comment 2 Rui Matos 2017-12-15 15:40:24 UTC 
Review of attachment 365590 [details] [review]:

this seems like it should be enough, but see also bug 790531
Comment 3 Ray Strode [halfline] 2017-12-15 15:52:29 UTC 
*** Bug 790531 has been marked as a duplicate of this bug. ***
Comment 4 Ray Strode [halfline] 2017-12-15 15:55:46 UTC 
alright, I think attachment 365590 [details] [review] is the better way to go because wall clocks aren't expensive to create, and so don't really need to be cached.  I do thing attachment 365590 [details] [review] would maybe make sense if some widely deployed versions of GnomeWallClock did leak timerfds, since it would mitigate that bug.

will push mine
Comment 5 Ray Strode [halfline] 2017-12-15 15:58:00 UTC 
Attachment 365590 [details] pushed as 94b96f8 - background: don't leak wall clock when background changes