After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791586 - Album art does not display due to error in MediaArt.buffer_to_jpeg (libmediaart)
Album art does not display due to error in MediaArt.buffer_to_jpeg (libmediaart)
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
3.26.x
Other Linux
: Normal major
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on: 792272
Blocks:
 
 
Reported: 2017-12-13 17:02 UTC by blub
Modified: 2018-01-10 00:24 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description blub 2017-12-13 17:02:23 UTC
When I open gnome-music I get hundreds of warnings:

17:57:12 WARNING	Error: <class 'TypeError'>, MediaArt.buffer_to_jpeg() takes exactly 4 arguments (3 given)

Calling libmediaart's MediaArt.buffer_to_jpeg fails due to a missing argument. This results in no media art being displayed at all.

Versions: libmediaart 1.9.4, gnome-music 3.26.1
Comment 1 Marinus Schraal 2017-12-13 18:48:06 UTC
What kind of file is this?
Comment 2 blub 2017-12-13 19:33:46 UTC
It's the terminal output:

---
[mjb@march ~]$ gnome-music
20:27:43 WARNING	Error: <class 'TypeError'>, MediaArt.buffer_to_jpeg() takes exactly 4 arguments (3 given)
20:27:43 WARNING	Error: <class 'TypeError'>, MediaArt.buffer_to_jpeg() takes exactly 4 arguments (3 given)
20:27:43 WARNING	Error: <class 'TypeError'>, MediaArt.buffer_to_jpeg() takes exactly 4 arguments (3 given)
20:27:43 WARNING	Error: <class 'TypeError'>, MediaArt.buffer_to_jpeg() takes exactly 4 arguments (3 given)
20:27:43 WARNING	Error: <class 'TypeError'>, MediaArt.buffer_to_jpeg() takes exactly 4 arguments (3 given)
20:27:43 WARNING	Error: <class 'TypeError'>, MediaArt.buffer_to_jpeg() takes exactly 4 arguments (3 given)
20:27:43 WARNING	Error: <class 'TypeError'>, MediaArt.buffer_to_jpeg() takes exactly 4 arguments (3 given)
20:27:44 WARNING	Error: <class 'TypeError'>, MediaArt.buffer_to_jpeg() takes exactly 4 arguments (3 given)
20:27:44 WARNING	Error: <class 'TypeError'>, MediaArt.buffer_to_jpeg() takes exactly 4 arguments (3 given)
---

In albumartcache.py the function is called with three arguments:

   MediaArt.buffer_to_jpeg(map_info.data, mime, cache_path)

But the function is defined in "extractpixbuf.c" as

   media_art_buffer_to_jpeg (const unsigned char  *buffer,
                             size_t                len,
                             const gchar          *buffer_mime,
                             const gchar          *target,
                             GError              **error)
Comment 3 Marinus Schraal 2017-12-14 15:11:47 UTC
I mean, what is the format of the file?
Comment 4 blub 2017-12-16 13:25:54 UTC
Oh sorry. Standard mp3. All the covers used to show up in older versions of gnome-music
Comment 5 Marinus Schraal 2017-12-18 11:32:33 UTC
What distribution?
Comment 6 blub 2017-12-20 18:55:09 UTC
Up-to-date Arch Linux
Comment 7 Marinus Schraal 2018-01-06 14:17:42 UTC
See #792272, libmediaart built with meson is currently not providing correct introspection. You should report this to the arch maintainers.
Comment 8 Marinus Schraal 2018-01-08 15:56:22 UTC
The fix has been integrated in libmediaart, notify your libmediaart package maintainers.

Thanks for your report.
Comment 9 blub 2018-01-08 17:35:17 UTC
Thank you so much for the fix. It's much appreciated.

I will notify the Arch maintainers as soon as there is a new release of libmediaart.
Comment 10 Marinus Schraal 2018-01-10 00:24:06 UTC
(In reply to mjb from comment #9)
> Thank you so much for the fix. It's much appreciated.
> 
> I will notify the Arch maintainers as soon as there is a new release of
> libmediaart.

I would suggest you notify them now. It is easy for maintainers to apply the patch and fix the package, libmediaart does not release often.