Created attachment 365468 [details] [review]
selection-toolbar: Port to GtkBuilder xml

Using GtkBuilder xml files for UI separates UI from program
logic. This helps simplify maitaining the code.

Created attachment 365469 [details] [review]
selection-toolbar: Port to GtkBuilder xml

Using GtkBuilder xml files for UI separates UI from program
logic. This helps simplify maitaining the code.

Review of attachment 365469 [details] [review]:

-  for (l=selection; l !=NULL; l=l->next)
+  for (l = selection; l != NULL; l = l->next)

I believe this is formatting change, so I wouldn't mix it up with this change.

+  /*
+   * HACK: When every item is deleted, Empty view is shown in the
+   * main window. Thus the action bar is hidden in the view.
+   * But it actually isn't. And the bar appears when the view
+   * is changed to Trash view.
+   * So hide the widget all together.
+   */
+  gtk_widget_hide (GTK_WIDGET (self));
+  gtk_revealer_set_reveal_child (GTK_REVEALER (self), FALSE);
   bjb_main_view_set_selection_mode (self->view, FALSE);

What about if we fix that in bjb_main_view_set_selection_mode?

Created attachment 365779 [details] [review]
selection-toolbar: Port to GtkBuilder xml

Using GtkBuilder xml files for UI separates UI from program
logic. This helps simplify maitaining the code.

(In reply to Isaque Galdino from comment #3) 
> I believe this is formatting change, so I wouldn't mix it up with this
> change.
> 
Fixed

> +  /*
> +   * HACK: When every item is deleted, Empty view is shown in the ...
> What about if we fix that in bjb_main_view_set_selection_mode?

It is possible, but I think it's better to delay until main-view and
window-base are ported to GtkBuilder, which will help us fix the issue
easier than adding yet another work around now.

Review of attachment 365779 [details] [review]:

Thanks.

(In reply to Mohammed Sadiq from comment #5)
> (In reply to Isaque Galdino from comment #3) 
> > +  /*
> > +   * HACK: When every item is deleted, Empty view is shown in the ...
> > What about if we fix that in bjb_main_view_set_selection_mode?
> 
> It is possible, but I think it's better to delay until main-view and
> window-base are ported to GtkBuilder, which will help us fix the issue
> easier than adding yet another work around now.

Agree.