Created attachment 365451 [details]
bug.c

The 'g_assert_cmpmem()' macro defined in the 'glib/gtestutils.h' header, uses the 'memcmp()' function of the stdlib without including the 'string.h' header.

Thus, the attached test program (bug.c), does not compile when the '-Werror' option is enabled. As shown by the following compiler error messages:

$ gcc -Werror -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include -lglib-2.0 bug.c
In file included from /usr/include/glib-2.0/glib.h:82:0,
                 from bug.c:1:
bug.c: In function ‘main’:
/usr/include/glib-2.0/glib/gtestutils.h:77:55: error: implicit declaration of function ‘memcmp’ [-Werror=implicit-function-declaration]
                                              else if (memcmp (__m1, __m2, __l1) != 0) \
                                                       ^
bug.c:8:5: note: in expansion of macro ‘g_assert_cmpmem’
     g_assert_cmpmem(foo, sizeof(foo), bar, sizeof(bar));
     ^
cc1: all warnings being treated as errors

I know, this might be a really easy bug fix. I am new to glib and I am not sure if it is okay just to add the '#include <string.h>' statement to the 'glib/gtestutils.h' header or if there is some more abstraction needed like a 'g_memcmp()' function or what ever?

Cheers,
Stefan