After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791463 - xvimagesink: fix inaccurate error message
xvimagesink: fix inaccurate error message
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal minor
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-12-11 03:19 UTC by Jun Xie
Modified: 2017-12-11 08:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix inaccurate error message (835 bytes, patch)
2017-12-11 03:20 UTC, Jun Xie 		committed Details | Review

Description Jun Xie 2017-12-11 03:19:28 UTC 
fix inaccurate error message
Comment 1 Jun Xie 2017-12-11 03:20:42 UTC 
Created attachment 365339 [details] [review]
fix inaccurate error message
Comment 2 Sebastian Dröge (slomo) 2017-12-11 08:30:21 UTC 
Please describe a bit more in the future what you're doing in the commit
message. Why was the error message inaccurate?

I've added a bit about that now before merging.

commit e0846de5b9e4e2f6e56618f756a4bb4cb0c32335 (HEAD -> master)
Author: Jun Xie <jun.xie@samsung.com>
Date:   Mon Dec 11 11:45:37 2017 +0800

    xvimagesink: fix inaccurate error message
    
    It's about not being able to calculate the display size, not the display
    ratio.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=791463
Comment 3 Jun Xie 2017-12-11 08:36:38 UTC 
Thanks, slomo.
I will provide more detailed info in future commit message.
This merged one is a good example to follow:)