After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791441 - Don't move around the New Tab button
Don't move around the New Tab button
Status: RESOLVED OBSOLETE
Product: epiphany
Classification: Core
Component: Interface
3.26.x
Other Linux
: Normal enhancement
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-12-10 14:18 UTC by Dan Jacobson
Modified: 2018-08-03 21:24 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Dan Jacobson 2017-12-10 14:18:38 UTC
Seems there always is extra room next to the URL slot. So maybe don't move the New Tab button out of being next to it and into the row below it, upon the change from there being only one tab to more than one.

That way ephy's interface would be more consistent.

Or only move it when there is really a long URL.
Comment 1 Michael Catanzaro 2017-12-12 21:53:19 UTC
Our designers requested that this go in the tab bar, so we'd either need to:

 * Keep the new tab icon in the top bar at all times, contradicting the designs; or
 * Always show the tab bar at all times (which *maybe* requires turning off tab expansion, since a single tab in a notebook does not look very good)

Always showing the tab bar would also resolve bug #791090, another design complaint.
Comment 2 Dan Jacobson 2017-12-13 00:15:29 UTC
I'm fine with both...
Comment 3 Jan-Michael Brummer 2018-02-10 21:43:39 UTC
I would suggest to leave the new tab button on the top. This will make it easier for touch interfaces to open new pages.
Comment 4 Michael Catanzaro 2018-02-11 19:17:44 UTC
(In reply to Jan-Michael Brummer from comment #3)
> I would suggest to leave the new tab button on the top. This will make it
> easier for touch interfaces to open new pages.

I tried this a couple weeks ago, but the new tab menu on the right of the tab bar looks a rather out of place with that change.
Comment 5 Jan-Michael Brummer 2018-02-11 19:35:28 UTC
I assume that you are just used to it. Nevertheless it looks like the best solution to come up with at the moment (and fixes touch as well).
Comment 6 Michael Catanzaro 2018-02-11 19:43:26 UTC
OK, but I don't want to break UI freeze for this, and I do want plenty of time to change my mind. If you want to submit a patch, then we can do this in master, but I will branch gnome-3-28 before pushing it.

Is it impossible to open a new tab currently from touchscreen, or just difficult?

Also: the new tab button should move back to the left side of the header bar, next to reload, to match gedit. That seems better than keeping it by the bookmarks. I had moved it to the right so it would have less distance to travel.
Comment 7 Jan-Michael Brummer 2018-02-11 19:46:21 UTC
No, it is not impossible and fine to do it in master after branching. This would perfectly match with a UI redesign (other bug tickets).
Comment 8 GNOME Infrastructure Team 2018-08-03 21:24:01 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/epiphany/issues/447.