After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791316 - gdbusproxy: make g-name-owner property useful with unique names
gdbusproxy: make g-name-owner property useful with unique names
Status: RESOLVED OBSOLETE
Product: glib
Classification: Platform
Component: gdbus
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2017-12-06 18:52 UTC by Cosimo Cecchi
Modified: 2018-05-24 19:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gdbusproxy: make g-name-owner property useful with unique names (1.97 KB, patch)
2017-12-06 18:53 UTC, Cosimo Cecchi 		reviewed Details | Review

Description Cosimo Cecchi 2017-12-06 18:52:59 UTC 
See attached patch.
Comment 1 Cosimo Cecchi 2017-12-06 18:53:02 UTC 
Created attachment 365139 [details] [review]
gdbusproxy: make g-name-owner property useful with unique names

Currently, GDBusProxy:g-name-owner only notifies changes to the unique
name owner of the remote object in case the proxy was constructed for a
well-known name.
That sounds like an artificial restriction, and it's convenient to
connect to notify::g-name-owner if a proxy instance has already been
created for an unique name, instead of additionally using
g_bus_watch_name() to track the owner.

To fix this, always connect to NameOwnerChanged after the proxy is
initialized, instead of only doing so when the proxy was constructed for
a well-known name.
Comment 2 Philip Withnall 2017-12-07 10:04:34 UTC 
Review of attachment 365139 [details] [review]:

This seems reasonable, but I’d like a unit test for it please. I don’t really want to push any more changes to GDBus without unit tests. You should be able to base something off gio/tests/gdbus-proxy-well-known-name.c and put it in gio/tests/gdbus-proxy.c, or refactor gdbus-proxy-well-known-name.c to test both well-known and unique names with notify::g-name-owner.
Comment 3 GNOME Infrastructure Team 2018-05-24 19:58:27 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/glib/issues/1310.