After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791204 - aggregator: rename pad_{get,steal}_buffer() to pad_{peek,pop}_buffer()
aggregator: rename pad_{get,steal}_buffer() to pad_{peek,pop}_buffer()
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal blocker
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-12-04 12:19 UTC by Tim-Philipp Müller
Modified: 2018-01-23 09:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Tim-Philipp Müller 2017-12-04 12:19:32 UTC 
From bug #739010:

I'm still very much inclined towards renaming

 gst_aggregator_pad_steal_buffer() -> gst_aggregator_pad_pop_buffer()
 gst_aggregator_pad_get_buffer() -> gst_aggregator_pad_peek_buffer()

It is true that get/steal is used elsewhere, but in a slightly different context. I think pop/peek describe what is done functionality-wise much better and avoid confusion about the return value ownership, e.g. with GValue _get() will not return a ref whereas _steal() will but here both do return a ref.
Comment 1 Sebastian Dröge (slomo) 2017-12-04 14:41:27 UTC 
+1
Comment 2 Tim-Philipp Müller 2018-01-23 09:53:26 UTC 
commit bce246f39f2093c2800d5034d54afa88b26908c2
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Tue Jan 23 08:56:34 2018 +0000

    aggregator: rename _get_buffer() -> _peek_buffer() and _steal -> _pop
    
    https://bugzilla.gnome.org/show_bug.cgi?id=791204