After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791130 - vapi: Gtk.Menu.popup() and popup_for_device() should be marked as deprecated
vapi: Gtk.Menu.popup() and popup_for_device() should be marked as deprecated
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Bindings: GTK+ GStreamer WebKitGTK+
0.39.x
Other Linux
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on: 730746
Blocks:
 
 
Reported: 2017-12-02 13:23 UTC by Sébastien Wilmet
Modified: 2017-12-10 19:13 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Sébastien Wilmet 2017-12-02 13:23:48 UTC
vapi: Gtk.Menu.popup() should be marked as deprecated.

gtk_menu_popup() and gtk_menu_popup_for_device() are deprecated.
Comment 1 Al Thomas 2017-12-02 17:35:12 UTC
There is a `Deprecated: x.xx` GObject Introspection annotation. Ideally that would feed through the GIR from the annotations in:
gtk_menu_popup (https://git.gnome.org/browse/gtk+/tree/gtk/gtkmenu.c#n1828)
gtk_menu_popup_for_device (https://git.gnome.org/browse/gtk+/tree/gtk/gtkmenu.c#n1761)

At present there are no annotations for that in the C source, but I'm not sure Vala would pick up on that if they were there.
Comment 2 Rico Tzschichholz 2017-12-10 19:09:22 UTC
Fixed with https://bugzilla.gnome.org/show_bug.cgi?id=730746
Comment 3 Sébastien Wilmet 2017-12-10 19:13:32 UTC
Thanks!