After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791070 - Refactor rtpsession tests to use GstHarness
Refactor rtpsession tests to use GstHarness
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal enhancement
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 791074
 
 
Reported: 2017-12-01 12:10 UTC by Håvard Graff (hgr)
Modified: 2017-12-02 13:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
test refactoring (34.02 KB, patch)
2017-12-01 12:10 UTC, Håvard Graff (hgr) 		committed Details | Review

Description Håvard Graff (hgr) 2017-12-01 12:10:29 UTC 
Created attachment 364744 [details] [review]
test refactoring

This patch simplifies the tests (44% less code) and makes then IMO much more readable.

The provided SessionHarness also makes it much easier to write new tests for rtpsession.
Comment 1 Tim-Philipp Müller 2017-12-02 13:06:52 UTC 
Pushed this, before it bitrots:

commit 96d837b301a4e7ffc119cc1cc034640b10ff476f
Author: Havard Graff <havard.graff@gmail.com>
Date:   Fri Dec 1 13:04:41 2017 +0100

    tests: rtpsession: refactor tests to use GstHarness
    
    This patch simplifies the tests (44% less code) and
    makes them much more readable.
    
    The provided SessionHarness also makes it much easier
    to write new tests for rtpsession.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=791070