GNOME Bugzilla – Bug 791034
rtpjitterbuffer fails to create ptp_clock
Last modified: 2017-12-01 08:11:13 UTC
Created attachment 364691 [details] [review] 0001-ptpclock-do-not-require-a-name-to-create-a-clock.patch The rtpjitterbuffer element tries to allocate a GstPtpClock without providing a name. However, gst_ptp_clock_new() asserts that name is not NULL and fails. This results in a fallback to not using the reference clock even though a valid PTP reference is published in the sdp and detected by the rtpjitterbuffer. I am not sure, if it is OK to remove the assertion, but looking at other elements it seems valid to not set the name in g_object_new(). If the assertion is correct, the rtpjitterbuffer must provide a name when instantiating the GstPtpClock. The patch is simple, but I don't know a proper name for this clock.
Created attachment 364692 [details] [review] 0001-ptpclock-do-not-require-a-name-to-create-a-clock.patch
Comment on attachment 364692 [details] [review] 0001-ptpclock-do-not-require-a-name-to-create-a-clock.patch Yes, just like the other netclocks. I'll merge later, thanks for the patch :)
commit bbafb78b1eb91c565347554a1d3e7f75b24664d7 (HEAD -> master) Author: Michael Tretter <m.tretter@pengutronix.de> Date: Thu Nov 30 17:49:10 2017 +0100 ptpclock: do not require a name to create a clock The gst_ptp_clock_new() does not actually require a name. However, for example the rtpjitterbuffer may create a clock without a name, fail, and fall back to not using the PTP clock. https://bugzilla.gnome.org/show_bug.cgi?id=791034