Created attachment 364322 [details] [review]
glib-tap: Add missing mkdir for .test generation rule

We can’t guarantee that the builddir we’re generating in actually exists
— if doing a clean build with builddir ≠ srcdir, and there are no other
rules which generate build products in builddir, the .test generation
rule can fail. This happens for flatpak-builder.git for me.

Try to avoid that by explicitly creating the builddir.

Signed-off-by: Philip Withnall <withnall@endlessm.com>

Review of attachment 364322 [details] [review]:

::: glib-tap.mk
@@ +127,2 @@
 %.test: %$(EXEEXT) Makefile
+	$(AM_V_GEN) (mkdir -p $(@D); \

You probably want to use `$(MKDIR_P)` here.

Review of attachment 364322 [details] [review]:

::: glib-tap.mk
@@ +127,2 @@
 %.test: %$(EXEEXT) Makefile
+	$(AM_V_GEN) (mkdir -p $(@D); \

There are loads of places in GLib which just use `mkdir -p`, but OK.

Thanks for the fast review.

Attachment 364322 [details] pushed as b97e5cb - glib-tap: Add missing mkdir for .test generation rule