After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790477 - Add more infos using icons
Add more infos using icons
Status: RESOLVED FIXED
Product: dconf-editor
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: dconf-editor maintainer(s)
dconf-editor maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-11-17 05:55 UTC by Arnaud B.
Modified: 2017-12-13 22:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add an icon next to edited keys. (3.58 KB, patch)
2017-12-12 15:57 UTC, Arnaud B.
none Details | Review
Do not mark edited values with bold. (4.61 KB, patch)
2017-12-12 15:58 UTC, Arnaud B.
none Details | Review
Add an icon next to edited keys. (3.69 KB, patch)
2017-12-12 16:07 UTC, Arnaud B.
none Details | Review
Do not mark edited values with bold. (4.45 KB, patch)
2017-12-12 20:37 UTC, Arnaud B.
none Details | Review

Description Arnaud B. 2017-11-17 05:55:50 UTC
“Icons” at the left of keys listbox rows are for now used:
 * for folders;
 * when a key with schema has a delayed modification;
 * when a key without schema is awaiting for suppression.

Now that there’s a clear distinction between folder rows and keys rows, we might convey more information there, including “edited or not” keys. There could be:
 * folders (like now);
 * maybe, schemas (an icon of folder with a little thing on it);
 * key with schema, default value (maybe a check mark, like “all is ok here”, ‘emblem-default-symbolic’);
 * key with schema, edited (‘document-edit-symbolic?’);
 * key without schema (maybe a ‘?’ in a circle icon);
 * key erased (the trash icon);
and maybe information about key awaiting for modification, in smaller icons, “emblems”:
 * modification delayed (for both keys without schema and keys with schema; maybe the clock icon, as used now);
 * key awaiting for suppression (for keys without schema; the trash icon used now);
 * and key awaiting for reset (for keys with schema –there’s a weird case were a key already reseted could be awaiting for reset; not sure of which icon to choose).

That would allow to not rely on random text being bold to know if a key is in dconf database (schema + edited, or no schema).

It needs thinking if a “all is good” key (with schema, default value) needs an icon or just an empty space.
Comment 1 Arnaud B. 2017-12-12 15:57:37 UTC
Created attachment 365435 [details] [review]
Add an icon next to edited keys.

So, a little update here.

Are now marked in ‘master’ branch:
 * folders;
 * keys with change delayed (both with or without schema; no distinction for the nature of the change for keys with schema);
 * keys  without schema (the icon could be improved);
 * keys (without schema) awaiting for suppression;
 * keys (without schema) removed.

Schemas are hard to mark, as multiple schemas and keys without schema could finish in the same directory.

Here are two patches, behaviour in testing. The first patch adds an icon next to edited keys with schema (nothing next to keys at default value, but might test ‘emblem-default-symbolic’), and the second to remove the “bold” marking on keys edited or without schema.
Comment 2 Arnaud B. 2017-12-12 15:58:03 UTC
Created attachment 365436 [details] [review]
Do not mark edited values with bold.
Comment 3 Arnaud B. 2017-12-12 16:07:09 UTC
Created attachment 365444 [details] [review]
Add an icon next to edited keys.
Comment 4 Arnaud B. 2017-12-12 20:37:13 UTC
Created attachment 365465 [details] [review]
Do not mark edited values with bold.
Comment 5 Davi 2017-12-13 21:54:03 UTC
With the last commits I'm having compile errors:

../../../../../../../../../Pessoal/dconf-editor/editor/pathbar.vala:159.35-159.38: warning: Argument 1: Cannot pass null to non-null parameter type
            item.set_action_name (null);
                                  ^^^^
../../../../../../../../../Pessoal/dconf-editor/editor/pathbar.vala:159.35-159.38: error: Argument 1: Cannot convert from `null' to `string'
            item.set_action_name (null);
                                  ^^^^

Seems like using the empty string works.
Comment 6 Arnaud B. 2017-12-13 22:05:26 UTC
I’ve just launched a complete rebuild, because I was hacking at the same time on Gtk+ for a problem on this exact call of the function. But I think it is correct as it is, even without the patch I’ve done targeting Gtk+. There might be a problem of updated Vala or so.
Comment 7 Arnaud B. 2017-12-13 22:14:00 UTC
Search “set_action_name” in this commit:
https://git.gnome.org/browse/vala/commit/?id=a8e6aff63e5e1502290ba93398314acf2ad45b60
Comment 8 Davi 2017-12-13 22:16:10 UTC
Looks like I'm compiling vala from git master now :).
Comment 9 Arnaud B. 2017-12-13 22:21:36 UTC
Sorry for the forced update, I’m usually compiling on ~master, so I don’t always know what has been updated only recently. But if you’re switching to master, I’ll also do the change of OPTION_REMAINING:
https://git.gnome.org/browse/vala/commit/?id=164abf4719b6d17a4e7287d4c0cfd5c5ba8611e8
(that is even more recent). ^^